Return-Path: 
 <derby-dev-return-31706-apmail-db-derby-dev-archive=db.apache.org@db.apache.org>
Delivered-To: apmail-db-derby-dev-archive@www.apache.org
Received: (qmail 31489 invoked from network); 11 Oct 2006 09:19:04 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 11 Oct 2006 09:19:04 -0000
Received: (qmail 91963 invoked by uid 500); 11 Oct 2006 09:19:02 -0000
Delivered-To: apmail-db-derby-dev-archive@db.apache.org
Received: (qmail 91937 invoked by uid 500); 11 Oct 2006 09:19:02 -0000
Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:derby-dev-help@db.apache.org>
List-Unsubscribe: <mailto:derby-dev-unsubscribe@db.apache.org>
List-Post: <mailto:derby-dev@db.apache.org>
List-Id: <derby-dev.db.apache.org>
Reply-To: <derby-dev@db.apache.org>
Delivered-To: mailing list derby-dev@db.apache.org
Received: (qmail 91928 invoked by uid 99); 11 Oct 2006 09:19:02 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Oct 2006 02:19:02 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Oct 2006 02:19:01 -0700
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 095877142E1
	for <derby-dev@db.apache.org>; Wed, 11 Oct 2006 02:18:21 -0700 (PDT)
Message-ID: <29379368.1160558301035.JavaMail.root@brutus>
Date: Wed, 11 Oct 2006 02:18:21 -0700 (PDT)
From: "Bernt M. Johnsen (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-1953) Make FOR EACH clause and MODE DB2SQL
 in CREATE TRIGGER statement optional
In-Reply-To: <17337844.1160501059564.JavaMail.root@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

    [ http://issues.apache.org/jira/browse/DERBY-1953?page=comments#action_12441383 ] 
            
Bernt M. Johnsen commented on DERBY-1953:
-----------------------------------------

No, I don't mind ;-) The change for DERBY-1770 is trivial anyway. Two comments though:

1) The standard syntax for <triggered action>:

<triggered action> ::=
     [ FOR EACH { ROW | STATEMENT } ]
     [ WHEN <left paren> <search condition> <right paren> ]
     <triggered SQL statement>

is now in Derby: 

<triggered action> ::=
     [ FOR EACH { ROW | STATEMENT } [MODE DB2SQL] ]
     [ WHEN <left paren> <search condition> <right paren> ]
     <triggered SQL statement>

One could have considered
         [ FOR EACH { ROW | STATEMENT } ] [MODE DB2SQL]
instead.

If MODE DB2SQL some time in the future ended up with some semantic meaning, it would have been nice to have it independent of the FOR EACH part of the statement. I'm not sure if it natters very much.

2) I was planning to change nearly all tests to go without MODE DB2SQL, and just keep the keywords in db2Compatility.sql. After all, it's harder to get the parser right without these keywords, so that should be the norm in the tests. I'll continue that part of my DERBY-1770 work, since Yip's patch just does some few test extensions.


> Make FOR EACH clause and MODE DB2SQL in CREATE TRIGGER statement optional
> -------------------------------------------------------------------------
>
>                 Key: DERBY-1953
>                 URL: http://issues.apache.org/jira/browse/DERBY-1953
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.2.1.6
>         Environment: Any
>            Reporter: Yip Ng
>         Assigned To: Yip Ng
>            Priority: Minor
>         Attachments: derby1953-trunk-diff01.txt, derby1953-trunk-diff02.txt, derby1953-trunk-stat01.txt, derby1953-trunk-stat02.txt
>
>
> According to SQL:2003 standard, section 11.39 <trigger definition>, under Syntax Rules item 8:
> If neither FOR EACH ROW nor FOR EACH STATEMENT is specified, then FOR EACH STATEMENT is implicit.
> [ FOR EACH { ROW | STATEMENT } ]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira