Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 16697 invoked from network); 12 Oct 2006 19:02:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 12 Oct 2006 19:02:27 -0000 Received: (qmail 27782 invoked by uid 500); 12 Oct 2006 19:02:23 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 27444 invoked by uid 500); 12 Oct 2006 19:02:21 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 27422 invoked by uid 99); 12 Oct 2006 19:02:20 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Oct 2006 12:02:20 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Oct 2006 12:02:19 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4CF997142E2 for ; Thu, 12 Oct 2006 12:01:36 -0700 (PDT) Message-ID: <19734128.1160679696312.JavaMail.jira@brutus> Date: Thu, 12 Oct 2006 12:01:36 -0700 (PDT) From: "Bryan Pendleton (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-1956) Remove stale code from the statement classes in the client driver In-Reply-To: <28213461.1160638176348.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/DERBY-1956?page=comments#action_12441836 ] Bryan Pendleton commented on DERBY-1956: ---------------------------------------- Thanks Knut Anders and Dan for the clarification. It makes sense to me, and I think that removing the dead code sounds good. > Remove stale code from the statement classes in the client driver > ----------------------------------------------------------------- > > Key: DERBY-1956 > URL: http://issues.apache.org/jira/browse/DERBY-1956 > Project: Derby > Issue Type: Improvement > Components: Network Client > Affects Versions: 10.3.0.0 > Reporter: Knut Anders Hatlen > Assigned To: Knut Anders Hatlen > Priority: Minor > Fix For: 10.3.0.0 > > Attachments: 1956.diff, 1956.stat > > > Statement and ParameterMetaData contain flags called escapedProcedureCallWithResult_. These flags might have had a function before, but now they are always false. They are used in many if-statements and make the code harder to read. Removing the flags and the code that is only executed when the flags are true, would simplify the code and make it more maintainable. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira