Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <17291179.1161027396062.JavaMail.jira@brutus>
Date: Mon, 16 Oct 2006 12:36:36 -0700 (PDT)
From: "Knut Anders Hatlen (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-1893) Convert
 largedata/lobLengthTests.java to junit
In-Reply-To: <1950513.1159366431202.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

    [ http://issues.apache.org/jira/browse/DERBY-1893?page=3Dcomments#actio=
n_12442681 ]=20
           =20
Knut Anders Hatlen commented on DERBY-1893:
-------------------------------------------

I have two comments to the patch (sorry I didn't notice before it was commi=
tted):

 - the suite method should have used suite.addTestSuite(LobLengthTest.class=
) instead of suite.addTest(new LobLengthTest("testXXX")). The way it is now=
, a new test case won't run automatically, and one might be led to belive t=
hat it succeeded when in fact it did not run.

 - the tearDown() method should set conn to null and call super.tearDown().=
 Tests not doing this have caused OutOfMemoryErrors before (DERBY-1845 and =
DERBY-1910). (It would be even better if the test class didn't have its own=
 instance variable for the connection since the BaseJDBCTestClass already h=
as many helper methods which remove the need for an explicit pointer to the=
 connection.)

> Convert largedata/lobLengthTests.java to junit
> ----------------------------------------------
>
>                 Key: DERBY-1893
>                 URL: http://issues.apache.org/jira/browse/DERBY-1893
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: =C3=98ystein Gr=C3=B8vlen
>         Assigned To: =C3=98ystein Gr=C3=B8vlen
>            Priority: Trivial
>         Attachments: derby1893.diff, derby1893.stat, derby1893_v2.diff, d=
erby1893_v2.stat
>
>


--=20
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: htt=
p://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira