db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1956) Remove stale code from the statement classes in the client driver
Date Thu, 12 Oct 2006 15:36:36 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1956?page=comments#action_12441775 ] 
            
Knut Anders Hatlen commented on DERBY-1956:
-------------------------------------------

It seems to be there to support a different parameter mapping for statements of this kind:

  CallableStatement cs = c.prepareCall("{ ? = call cos(?) }");

If the flag is true, cs.setDouble(2, Math.PI) puts the parameter value into the first element
of the internal parameter array instead of the second element.

It also short-circuits CallableStatement.registerOutParameter() if the parameter index is
1. This could indicate that at some point registerOutParameter() was not needed to register
the result parameter.

> Remove stale code from the statement classes in the client driver
> -----------------------------------------------------------------
>
>                 Key: DERBY-1956
>                 URL: http://issues.apache.org/jira/browse/DERBY-1956
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.3.0.0
>            Reporter: Knut Anders Hatlen
>         Assigned To: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: 1956.diff, 1956.stat
>
>
> Statement and ParameterMetaData contain flags called escapedProcedureCallWithResult_.
These flags might have had a function before, but now they are always false. They are used
in many if-statements and make the code harder to read. Removing the flags and the code that
is only executed when the flags are true, would simplify the code and make it more maintainable.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message