db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernt M. Johnsen (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1953) Make FOR EACH clause and MODE DB2SQL in CREATE TRIGGER statement optional
Date Wed, 11 Oct 2006 09:18:21 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1953?page=comments#action_12441383 ] 
            
Bernt M. Johnsen commented on DERBY-1953:
-----------------------------------------

No, I don't mind ;-) The change for DERBY-1770 is trivial anyway. Two comments though:

1) The standard syntax for <triggered action>:

<triggered action> ::=
     [ FOR EACH { ROW | STATEMENT } ]
     [ WHEN <left paren> <search condition> <right paren> ]
     <triggered SQL statement>

is now in Derby: 

<triggered action> ::=
     [ FOR EACH { ROW | STATEMENT } [MODE DB2SQL] ]
     [ WHEN <left paren> <search condition> <right paren> ]
     <triggered SQL statement>

One could have considered
         [ FOR EACH { ROW | STATEMENT } ] [MODE DB2SQL]
instead.

If MODE DB2SQL some time in the future ended up with some semantic meaning, it would have
been nice to have it independent of the FOR EACH part of the statement. I'm not sure if it
natters very much.

2) I was planning to change nearly all tests to go without MODE DB2SQL, and just keep the
keywords in db2Compatility.sql. After all, it's harder to get the parser right without these
keywords, so that should be the norm in the tests. I'll continue that part of my DERBY-1770
work, since Yip's patch just does some few test extensions.


> Make FOR EACH clause and MODE DB2SQL in CREATE TRIGGER statement optional
> -------------------------------------------------------------------------
>
>                 Key: DERBY-1953
>                 URL: http://issues.apache.org/jira/browse/DERBY-1953
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.2.1.6
>         Environment: Any
>            Reporter: Yip Ng
>         Assigned To: Yip Ng
>            Priority: Minor
>         Attachments: derby1953-trunk-diff01.txt, derby1953-trunk-diff02.txt, derby1953-trunk-stat01.txt,
derby1953-trunk-stat02.txt
>
>
> According to SQL:2003 standard, section 11.39 <trigger definition>, under Syntax
Rules item 8:
> If neither FOR EACH ROW nor FOR EACH STATEMENT is specified, then FOR EACH STATEMENT
is implicit.
> [ FOR EACH { ROW | STATEMENT } ]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message