db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <derby-...@db.apache.org>
Subject [jira] Updated: (DERBY-1956) Remove stale code from the statement classes in the client driver
Date Thu, 12 Oct 2006 07:46:36 GMT
     [ http://issues.apache.org/jira/browse/DERBY-1956?page=all ]

Knut Anders Hatlen updated DERBY-1956:
--------------------------------------

    Attachment: 1956.diff
                1956.stat

Attaching a patch which removes escapedProcedureCallWithResult_ and all code that is only
executed when the flag is true. The patch also removes a couple of methods that became no-ops,
and SQLStates and messages that are never used. Derbyall ran cleanly with the changes. The
patch is ready for review.

> Remove stale code from the statement classes in the client driver
> -----------------------------------------------------------------
>
>                 Key: DERBY-1956
>                 URL: http://issues.apache.org/jira/browse/DERBY-1956
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.3.0.0
>            Reporter: Knut Anders Hatlen
>         Assigned To: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: 1956.diff, 1956.stat
>
>
> Statement and ParameterMetaData contain flags called escapedProcedureCallWithResult_.
These flags might have had a function before, but now they are always false. They are used
in many if-statements and make the code harder to read. Removing the flags and the code that
is only executed when the flags are true, would simplify the code and make it more maintainable.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message