Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: neutral (asf.osuosl.org: local policy)
Message-ID: <44F8A73D.2090105@apache.org>
Date: Fri, 01 Sep 2006 14:33:49 -0700
From: Daniel John Debrunner <djd@apache.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.7.3) Gecko/20040910
MIME-Version: 1.0
To: derby-dev <derby-dev@db.apache.org>
Subject: GRANT/REVOKE - unneeded complexity in PrivilegeNode??
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit


In reviewing the patch for DERBY-1686 I cam across this code.

class PrivilegeNode
method
bind( HashMap dependencies, List grantees )

        if( dependencyProvider != null)
        {
            if( dependencies.get( dependencyProvider) == null)
            {
                getCompilerContext().createDependency( dependencyProvider);
                dependencies.put( dependencyProvider, dependencyProvider);
            }
        }

The dependencyProvider is driven from the objectOfPrivilege of which
there is one in PrivilegeNode.

So the questions are:

1) Since bind() is called once for PrivilegeNode how can there ever be
anything in the HashMap?

2) Since the dependency manager happily copes with object being
dependent on the same item multiple times, why does this code even exist?

If there's no good reason for it then I'll clean it up.

Dan.