Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <1498642.1157540243510.JavaMail.jira@brutus>
Date: Wed, 6 Sep 2006 03:57:23 -0700 (PDT)
From: "Kristian Waagan (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-1802) JUnit tests for DERBY-475 and
 DERBY-592, Built-in and JDBC escape functions
In-Reply-To: <30722473.1157127502372.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/DERBY-1802?page=comments#action_12432819 ] 
            
Kristian Waagan commented on DERBY-1802:
----------------------------------------

Hi Susan,

Thanks for writing these tests :)
I had a look and have a few comments. 2 and 3 are nits, use your own judgement.
1) Is it possible to use the existing debug method 'println' instead of 'debug'?
   This can be enabled without recompiling the test by passing a property.

2) What about a line of commentary to the private helper methods, especially the ones that don't take a value?
   I had to spend a little time thinking about why you would need that, until PI popped up in my head :)

3) Since each test method is actually testing many things, explanatory messages in the assert-methods could be helpful (if they provide extra value).
   For instance in 'executeNullValues'; assertNull("Null output expected on null input", rValue)


Regards,

> JUnit tests for DERBY-475 and DERBY-592, Built-in and JDBC escape functions
> ---------------------------------------------------------------------------
>
>                 Key: DERBY-1802
>                 URL: http://issues.apache.org/jira/browse/DERBY-1802
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Susan Cline
>         Assigned To: Susan Cline
>            Priority: Minor
>         Attachments: DERBY-475_DERBY-592_20060831.diff, DERBY-475_DERBY-592_20060905.diff
>
>
> Attached is a patch which contains JUnit tests for DERBY-475 and DERBY-592, the built-in math functions and JDBC escape functions.
> I ran the patch, DERBY-475_DERBY-592_20060831.diff, against these four tests:
> java junit.textui.TestRunner org.apache.derbyTesting.functionTests.tests.lang.MathTrigFunctionsTest
> java org.apache.derbyTesting.functionTests.harness.RunTest lang/MathTrigFunctionsTest.junit
> java org.apache.derbyTesting.functionTests.harness.RunTest lang/_Suite.junit
> java org.apache.derbyTesting.functionTests.harness.RunSuite derbylang
> svn status:
> A      java\testing\org\apache\derbyTesting\functionTests\tests\lang\MathTrigFunctionsTest.java
> M      java\testing\org\apache\derbyTesting\functionTests\tests\lang\_Suite.java
> M      java\testing\org\apache\derbyTesting\functionTests\tests\lang\LangScripts.java
> (Note: I edited this file, but changed it back to the original contents.)
> I created the patch on Windows XP, tested it on Windows XP and then applied the patch on Linux and ran the above 4 tests on Linux.
> sysinfo output:
> ------------------ Java Information ------------------
> Java Version:    1.4.2_09
> Java Vendor:     Sun Microsystems Inc.
> Java home:       C:\JDK\jdk1.4.2_09\jre
> Java classpath:  C:\derby_src\development_branch\trunk\classes;C:\derby_src\deve
> lopment_branch\trunk\tools\java\junit.jar;C:\derby_src\development_branch\trunk\
> tools\java\jakarta-oro-2.0.8.jar;.
> OS name:         Windows XP
> OS architecture: x86
> OS version:      5.1
> Java user name:  slc
> Java user home:  C:\Documents and Settings\Administrator
> Java user dir:   C:\derby_src\development_branch\trunk
> java.specification.name: Java Platform API Specification
> java.specification.version: 1.4
> --------- Derby Information --------
> JRE - JDBC: J2SE 1.4.2 - JDBC 3.0
> [C:\derby_src\development_branch\trunk\classes] 10.3.0.0 alpha - (1)
> ------------------------------------------------------
> ----------------- Locale Information -----------------
> Current Locale :  [English/United States [en_US]]
> Found support for locale: [de_DE]
>          version: 10.3.0.0 alpha - (1)
> Found support for locale: [es]
>          version: 10.3.0.0 alpha - (1)
> Found support for locale: [fr]
>          version: 10.3.0.0 alpha - (1)
> Found support for locale: [it]
>          version: 10.3.0.0 alpha - (1)
> Found support for locale: [ja_JP]
>          version: 10.3.0.0 alpha - (1)
> Found support for locale: [ko_KR]
>          version: 10.3.0.0 alpha - (1)
> Found support for locale: [pt_BR]
>          version: 10.3.0.0 alpha - (1)
> Found support for locale: [zh_CN]
>          version: 10.3.0.0 alpha - (1)
> Found support for locale: [zh_TW]
>          version: 10.3.0.0 alpha - (1)
> ------------------------------------------------------
> I would appreciate it if a committer would commit this patch.
> Thanks,
> Susan

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira