db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <derby-...@db.apache.org>
Subject [jira] Updated: (DERBY-1618) store/BootAllTest.junit fails on with jdk13 based jvms
Date Fri, 01 Sep 2006 17:33:23 GMT
     [ http://issues.apache.org/jira/browse/DERBY-1618?page=all ]

Myrna van Lunteren updated DERBY-1618:

    Attachment: DERBY-1618_20060901.diff

Attaching a patch which I think addresses this issue. 
The patch changes these files:
M      java\engine\org\apache\derby\impl\io\DirStorageFactory.java
M      java\testing\org\apache\derbyTesting\functionTests\tests\lang\GetPropertyInfoTest.java
M      java\testing\org\apache\derbyTesting\functionTests\master\GetPropertyInfoTest.out

It appeared to me that for some reason, with jdk131, in the situation invoked by the testSettingBootAllPropertyWithHomePropertySet()
test in BootAllTest.java, when the DriverPropertyInfo.choices were accessed, the problem was
because in BaseMonitor.java there were no elements found resulting from provider.getBootTimeServices(),
which was because in StorageFactoryService the following:
                            StorageFile properties = storageFactory.newStorageFile( PersistentService.PROPERTIES_NAME);
                            if (!properties.exists())
resulted in no properties files found. Here, however, I found that the properties with jdk14
had a path prepended, but jdk13 did not. 
And this was because of DirStorageFactory4 prepending the canonicalName, but DirStorageFactory

So this patch copies a section of code of DirStorageFactory4.
That fixes the failure in BootAllTest.java with jdk131 and ibm131. Derbyall passes with jdk14
(except for failure in CheckDataSource, which also fails in nightlies, so is unrelated). Still
running with ibm131.

If a reviewer has a suggestion of where this can be placed better, I'd be interested. 

I modified the test lang/GetPropertyInfoTest.java to access the choices, description, and
required fields, but it didn't actually duplicate the problem in BootAllTest.java. But as
that's in that test I thought it was unnecessary to add more...

Poking further showed that th

> store/BootAllTest.junit fails on with jdk13 based jvms
> ------------------------------------------------------
>                 Key: DERBY-1618
>                 URL: http://issues.apache.org/jira/browse/DERBY-1618
>             Project: Derby
>          Issue Type: Bug
>          Components: Regression Test Failure
>    Affects Versions:
>         Environment: windows. (insane jars) alpha - (426734)
>            Reporter: Sunitha Kambhampati
>         Assigned To: Myrna van Lunteren
>             Fix For:
>         Attachments: DERBY-1618_20060901.diff
> bootAll test fails on ibm131, wctme5.7.
> ********* Diff file derbyall/storeall/storemore/BootAllTest.diff
> *** Start: BootAllTest jdk1.3.1 storeall:storemore 2006-07-30 06:35:16 ***
> 0 add
> > .F
> > There was 1 failure:
> > 1) testSettingBootAllPropertyWithHomePropertySet(org.apache.derbyTesting.functionTests.tests.store.BootAllTest)junit.framework.AssertionFailedError:
The number of databases should be expected:<3> but was:<0>
> > Tests run: 1,  Failures: 1,  Errors: 0
> Test Failed.
> *** End:   BootAllTest jdk1.3.1 storeall:storemore 2006-07-30 06:35:35 ***

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message