db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John H. Embretsen (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability
Date Mon, 18 Sep 2006 10:56:23 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12435458 ] 
            
John H. Embretsen commented on DERBY-1547:
------------------------------------------

Thanks for uploading a new patch so quickly, Narayanan! 

The only comment I have from reading the diff is that you seem to have missed one of Andrew's
points, namely the fact that the new regEx pattern will actually replace two old patterns.
Specifically, this means that all instances of the "[ ][-][ ][(][1][)];-(EXPECTED SUBVERSION
INFO)" substitution may be removed from the patch, and it should still work, both when running
with jars and when running with the classes directory in the classpath.

> Add svn version  number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion()
 to improve supportability
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1547
>                 URL: http://issues.apache.org/jira/browse/DERBY-1547
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.1.3.2
>            Reporter: Kathey Marsden
>         Assigned To: V.Narayanan
>            Priority: Minor
>             Fix For: 10.2.1.0
>
>         Attachments: DERBY-1547-sed-v1.diff, DERBY-1547-sed-v1.stat, DERBY-1547-sed-v2.diff,
DERBY-1547-sed-v2.stat, DERBY-1547-sed.diff, DERBY-1547-sed.stat, DERBY-1547_v1.diff, DERBY-1547_v1.stat,
derbyall_fail.txt
>
>
> getDatabaseProductVersion and getDriverVersion() report only the four digit Derby version
number and not the svn build number.   It would be useful to return  the full version including
the build number  as sysinfo does: e.g. "10.1.2.4 - (392472)", That way it will be clear from
application logs that collect this information exactly what revision level they are running
if they are using rolled up fixes on the maintenance branch between releases.
> There may be risk in doing this however if applications are parsing the version information,
but hopefully they will use getDatabaseMajorVersion() , getDatbaseMinorVersion, getDriverMajorVersion,
and getDriverMinorVersion for such proccessing.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message