db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
Date Tue, 12 Sep 2006 18:40:23 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12434234 ] 
            
Knut Anders Hatlen commented on DERBY-1610:
-------------------------------------------

Thank you for the explanation and the new patch, Tomohito!

Since the constant arrays are required to be sorted, I think they
should have a comment saying they must be sorted in case someone needs
to modify them later. Also, I think it would be clearer (and safer) if
they were defined as

  CONSTANT = Arrays.sort(new int[] { .... });

That would explicitly show that they are sorted. Since the sorting
only happens when the class is loaded, it shouldn't be a performance
issue.

Another small comment is that POSSIBLE_TYPES_IN_SET_XXX is identical
for boolean, byte, short, int, long, float, double and BigDecimal. It
would probably be good to use one constant only (for instance,
POSSIBLE_TYPES_IN_SET_SCALAR). It would reduce the disk and memory
footprint. The same comment is valid for the
POSSIBLE_TYPES_FOR_XXX_NULL constants.

(In fact, for the types mentioned above, the
POSSIBLE_TYPES_FOR_XXX_NULL constants could also be used by the setXXX
methods. The only difference between FOR_XXX_NULL and IN_SET_XXX, is
that the setNull constants contain BIT, TINYINT, NUMERIC and FLOAT
whereas the setXXX ones don't. Since these types also are compatible
with int, byte, boolean etc., it wouldn't hurt to add them to the
setXXX constants.)

I don't know what is meant by "XCL12 is temp" in parameterMapping, but
I assume it's because the one who wrote it meant only one SQL state
should be used for all conversion errors.

> Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-1610
>                 URL: http://issues.apache.org/jira/browse/DERBY-1610
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Server, Network Client
>            Reporter: Tomohito Nakayama
>         Assigned To: Tomohito Nakayama
>         Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff,
parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient,
parameterMapping_3.diff, TestNullChar.java, XCL12.diff
>
>
> There exists difference of type compatibility between  Embedded and NetworkServer/NetworkClient.
> This issue tries to resolve it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message