db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "V.Narayanan (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability
Date Fri, 08 Sep 2006 03:00:23 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12433301 ] 
            
V.Narayanan commented on DERBY-1547:
------------------------------------

Hi,
Thank You for the review on the patch

The patch DERBY-1547-sed.diff has this diff for NetworkServerControlImpl.java

Index: java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java
===================================================================
--- java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java	(revision 440712)
+++ java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java	(working copy)
@@ -336,7 +336,7 @@
 		att_extnam = ATT_SRVNAM + " " + java.lang.Thread.currentThread().getName();
 		
 		att_srvclsnm = myPVH.getProductName();
-		versionString = myPVH.getVersionBuildString(false);
+		versionString = myPVH.getVersionBuildString(true);
 		
 		String majorStr = String.valueOf(myPVH.getMajorVersion());
 		String minorStr = String.valueOf(myPVH.getMinorVersion());
@@ -360,7 +360,7 @@
 		prdId += minorStr;
 		
 		prdId += drdaMaintStr;
-		att_srvrlslv = prdId + "/" + myPVH.getVersionBuildString(false);
+		att_srvrlslv = prdId + "/" + myPVH.getVersionBuildString(true);
                 // Precompute this to save some cycles
                 prdIdBytes_ = prdId.getBytes(DEFAULT_ENCODING);
  
The only changes are 

+		versionString = myPVH.getVersionBuildString(true);
+		att_srvrlslv = prdId + "/" + myPVH.getVersionBuildString(true);

There are no exception related changes. I tried a find on the editor for the phrases StandardException
and EmbedSQLException on the patch. The phrases don't seem to exist. Or maybe that I am doing
something wrong here. I tried twice to recheck the above in the patch.

> Add svn version  number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion()
 to improve supportability
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1547
>                 URL: http://issues.apache.org/jira/browse/DERBY-1547
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.1.3.2
>            Reporter: Kathey Marsden
>         Assigned To: V.Narayanan
>            Priority: Minor
>             Fix For: 10.2.1.0
>
>         Attachments: DERBY-1547-sed.diff, DERBY-1547-sed.stat, DERBY-1547_v1.diff, DERBY-1547_v1.stat,
derbyall_fail.txt
>
>
> getDatabaseProductVersion and getDriverVersion() report only the four digit Derby version
number and not the svn build number.   It would be useful to return  the full version including
the build number  as sysinfo does: e.g. "10.1.2.4 - (392472)", That way it will be clear from
application logs that collect this information exactly what revision level they are running
if they are using rolled up fixes on the maintenance branch between releases.
> There may be risk in doing this however if applications are parsing the version information,
but hopefully they will use getDatabaseMajorVersion() , getDatbaseMinorVersion, getDriverMajorVersion,
and getDriverMinorVersion for such proccessing.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message