Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 95662 invoked from network); 24 Aug 2006 18:46:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 24 Aug 2006 18:46:40 -0000 Received: (qmail 40746 invoked by uid 500); 24 Aug 2006 18:46:40 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 40709 invoked by uid 500); 24 Aug 2006 18:46:39 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 40700 invoked by uid 99); 24 Aug 2006 18:46:39 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Aug 2006 11:46:39 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [63.82.107.6] (HELO red.amberpoint.com) (63.82.107.6) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Aug 2006 11:46:37 -0700 Received: from [127.0.0.1] (bpendleton-dsk2.edgility.com [10.10.11.13]) by red.amberpoint.com (8.12.11/8.12.11) with ESMTP id k7OIkQS3000801 for ; Thu, 24 Aug 2006 11:46:27 -0700 (PDT) Message-ID: <44EDF3F7.2010003@amberpoint.com> Date: Thu, 24 Aug 2006 11:46:15 -0700 From: Bryan Pendleton User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: derby-dev@db.apache.org Subject: Re: "Phase 7" patch for DERBY-688 posted. References: <44EDCAE4.4020902@gmail.com> In-Reply-To: <44EDCAE4.4020902@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N I am currently reviewing the phase 7 patch and running some tests. So far, everything looks good to me; thanks for the clean patch, Army! I intend to commit this patch to the trunk this evening unless any review issues show up. I also intend to merge this patch back to the 10.2 branch. The separation of the two remaining issues into DERBY-1758 and DERBY-1759 seems fine to me. I think DERBY-688 will be complete enough for 10.2 as of the phase 7 patch. If anyone has review comments on the phase 7 patch, be sure to copy the list directly, and not just put them in JIRA, until the JIRA email lagging problem gets resolved. thanks, bryan