Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 51113 invoked from network); 23 Aug 2006 20:53:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 23 Aug 2006 20:53:50 -0000 Received: (qmail 45366 invoked by uid 500); 23 Aug 2006 20:53:49 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 45333 invoked by uid 500); 23 Aug 2006 20:53:49 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 45324 invoked by uid 99); 23 Aug 2006 20:53:49 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Aug 2006 13:53:49 -0700 X-ASF-Spam-Status: No, hits=1.9 required=10.0 tests=DNS_FROM_RFC_ABUSE,DNS_FROM_RFC_POST X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [32.97.182.145] (HELO e5.ny.us.ibm.com) (32.97.182.145) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Aug 2006 13:53:48 -0700 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e5.ny.us.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k7NKrQph024175 for ; Wed, 23 Aug 2006 16:53:26 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay02.pok.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id k7NKrQop270118 for ; Wed, 23 Aug 2006 16:53:26 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k7NKrPdN014052 for ; Wed, 23 Aug 2006 16:53:25 -0400 Received: from [127.0.0.1] (sig-9-76-202-87.mts.ibm.com [9.76.202.87]) by d01av03.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k7NKrOIF014013 for ; Wed, 23 Aug 2006 16:53:25 -0400 Message-ID: <44ECC03E.5060405@sbcglobal.net> Date: Wed, 23 Aug 2006 13:53:18 -0700 From: Mike Matrigali Reply-To: mikem_app@sbcglobal.net User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: derby-dev@db.apache.org Subject: Re: Review/commit request for DERBY-1130 References: <58ed70f50608231150h61a15935g3e69b646ae9fcb5c@mail.gmail.com> In-Reply-To: <58ed70f50608231150h61a15935g3e69b646ae9fcb5c@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N It looks like this patch addresses comments from original review by David and Dan. DERBY-1130 is: Client should not allow databaseName to be set with setConnectionAttributes Deepa Remesh wrote: > Can someone please review this? It is a small patch. > http://issues.apache.org/jira/browse/DERBY-1130 > > Thanks, > Deepa > >