Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 44984 invoked from network); 22 Aug 2006 11:15:03 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Aug 2006 11:15:03 -0000 Received: (qmail 78547 invoked by uid 500); 22 Aug 2006 11:15:03 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 78517 invoked by uid 500); 22 Aug 2006 11:15:02 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 78504 invoked by uid 99); 22 Aug 2006 11:15:02 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2006 04:15:02 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=UNPARSEABLE_RELAY X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.18.1.36] (HELO gmpea-pix-1.sun.com) (192.18.1.36) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2006 04:15:00 -0700 Received: from d1-emea-09.sun.com (d1-emea-09.sun.com [192.18.2.119] (may be forged)) by gmpea-pix-1.sun.com (8.13.6+Sun/8.12.9) with ESMTP id k7MBEbq0008775 for ; Tue, 22 Aug 2006 12:14:39 +0100 (BST) Received: from conversion-daemon.d1-emea-09.sun.com by d1-emea-09.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) id <0J4E00C01CJNFF00@d1-emea-09.sun.com> (original mail from Kristian.Waagan@Sun.COM) for derby-dev@db.apache.org; Tue, 22 Aug 2006 12:14:37 +0100 (BST) Received: from [129.159.112.188] by d1-emea-09.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) with ESMTPSA id <0J4E00MF8CKC3EPR@d1-emea-09.sun.com> for derby-dev@db.apache.org; Tue, 22 Aug 2006 12:14:37 +0100 (BST) Date: Tue, 22 Aug 2006 13:14:36 +0200 From: Kristian Waagan Subject: Re: [junit] Move JUnit base/utility classes??? In-reply-to: <44E331AE.20400@apache.org> Sender: Kristian.Waagan@Sun.COM To: derby-dev@db.apache.org Message-id: <44EAE71C.6000905@Sun.com> Organization: Sun Microsystems Inc. MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT References: <44E21B61.8060402@apache.org> <44E237B7.60206@sun.com> <44E30089.9010802@sun.com> <44E31CDA.9080907@apache.org> <44E321EF.9060808@sun.com> <44E331AE.20400@apache.org> User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; no-NO; rv:1.8.0.5) Gecko/20060730 Thunderbird/1.5.0.5 Mnenhy/0.7.4.0 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Daniel John Debrunner wrote: > >>> I don't see any value in this, the existing layput looks fine to me. >>> >>> org.apache.derbyTesting.junit.functionalTests.tests.jdbcapi >>> org.apache.derbyTesting.junit.unitTests.lang >>> org.apache.derbyTesting.junit.systemTests.app1 (future) >>> >> (Note: existing layout does not have .junit.) > (sorry copy & paste error) > >> The value would have been to separate out the junit tests from the other >> tests, however I understand it is not prioritized and possibly not worth >> the effort. > > once they are all JUnit though there is no benefit :-) Hi, I still have a question regarding the placement of JUnit tests. I have brought this up before, but got very little response (I did get some, see below). Do we want to support [unit] testing of package private classes? The easiest solution to achieve this is to keep a mirrored/separate source tree, where the tests are put into the corresponding Derby production code package (for instance 'org.apache.derby.iapi.types'). Andrew brought up the concern wrt building and distribution. We do not want to include the testing classes in the releases. Further, JAR sealing is causing headaches (unable to distribute the test classes in a separate JAR). If people have more opinions at this time, I would like to hear them. If not, I'll nag the list again at a later time :) -- Kristian > > Dan. >