Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <31334553.1156246637367.JavaMail.jira@brutus>
Date: Tue, 22 Aug 2006 04:37:17 -0700 (PDT)
From: "V.Narayanan (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-1547) Add svn version  number to
 DatabaseMetaData getDatabaseProductVersion and getDriverVersion()  to
 improve supportability
In-Reply-To: <11729882.1153401073826.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12429677 ] 
            
V.Narayanan commented on DERBY-1547:
------------------------------------

Thank you for the comments on the patch. Going by your comments of using existing property files would it be possible to take a clue from the way this is done in the EmbeddedServer and client currently and get the product version the following way

The class ProductVersionHolder is used to get derby product information in Embedded Server,Client and tools as a result of which it is a part of derby.jar,derbyclient.jar and derbytools.jar. The property files using which the information is constructed for each Genus or each product category are 

Embedded - DBMS.properties
Client           - dnc.properties
tools             - tools.properties

1) In the tests I would need the driver versions in the embedded and the network client case. 

   I can get the product version in both the cases using the ProductVersionHolder class. For this
   I would need to have ProductVersionHolder class and files DBMS.properties and tools.properties
   in derbyTesting.jar. 

2) When I need to get the version string for the EmbeddedServer I would do the following

    InputStream versionStream = getClass().getResourceAsStream(ProductGenusNames.DBMS_INFO);
    engineVersion = ProductVersionHolder.getProductVersionHolderFromMyEnv(versionStream);


> Add svn version  number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion()  to improve supportability
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1547
>                 URL: http://issues.apache.org/jira/browse/DERBY-1547
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.1.3.2
>            Reporter: Kathey Marsden
>         Assigned To: V.Narayanan
>            Priority: Minor
>             Fix For: 10.2.1.0
>
>         Attachments: DERBY-1547_v1.diff, DERBY-1547_v1.stat
>
>
> getDatabaseProductVersion and getDriverVersion() report only the four digit Derby version number and not the svn build number.   It would be useful to return  the full version including the build number  as sysinfo does: e.g. "10.1.2.4 - (392472)", That way it will be clear from application logs that collect this information exactly what revision level they are running if they are using rolled up fixes on the maintenance branch between releases.
> There may be risk in doing this however if applications are parsing the version information, but hopefully they will use getDatabaseMajorVersion() , getDatbaseMinorVersion, getDriverMajorVersion, and getDriverMinorVersion for such proccessing.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira