db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanket Sharma" <sanketsha...@gmail.com>
Subject Re: [jira] Commented: (DERBY-1387) Add JMX extensions to Derby
Date Mon, 21 Aug 2006 15:26:42 GMT
On 8/21/06, Andreas Korneliussen (JIRA) <derby-dev@db.apache.org> wrote:
>    [ http://issues.apache.org/jira/browse/DERBY-1387?page=comments#action_12429432 ]
>
> Andreas Korneliussen commented on DERBY-1387:
> ---------------------------------------------
>
> Hi, thanks for providing this patch. I have tried compiling it, and I do have the following
comments:
>
> 1. It seems that most of the classes have multiple entries in the patch file, so when
applying the patch, I got the same class multiple times in the same file.

I'm not able to follow what you are trying to point out. Are you
referring to the imports? Can you please explain so that I may look
back at the patch and correct? This is the first time I've submitted
anything using svn diff. Any help would be appriciated.

>
> 2. After fixing 1, all code, except one class seems to be able to compile with JDK 1.4.
The class which depends on JDK 1.5 is BasicManagementService. It uses java.lang.management.ManagementFactory
to create the MBeanServer. Instead I would propose simply using javax.management.MBeanServerFactory.
This would allow the code to be compiled on JDK 1.4.


Although It will allow the code to compile against JDK1.4, I guess we
will be missing out a log of functionality provided by the
PlatformMBean server including vital CPU, threads, memory and heap, VM
etc. All that might be lost when we use a plain MBeanServer. Moreover,
JDK1.5 onwards, Sun suggests the use of PlatformMBean Server inplace
of plain MBean Server.
>
> If you do need the JDK 1.5 libraries, the build files must be set up so that it is still
possible to compile on JDK 1.4 (ie. by skipping the JMX targets).

Aaah..the build file. I'll add conditional checks there for checking
JDK1.5 and above.


Thank you for your comments!

Best Regards,
Sanket Sharma

Mime
View raw message