db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olav Sandstaa (JIRA)" <derby-...@db.apache.org>
Subject [jira] Created: (DERBY-1783) Logical error in code for determining mode for opening of log files
Date Wed, 30 Aug 2006 10:07:22 GMT
Logical error in code for determining mode for opening of log files

                 Key: DERBY-1783
                 URL: http://issues.apache.org/jira/browse/DERBY-1783
             Project: Derby
          Issue Type: Bug
          Components: Store
    Affects Versions:
         Environment: JVM 1.4.2 and later
            Reporter: Olav Sandstaa
            Priority: Trivial

There is a logical error in the following function in DirFile4.java
for determining which mode to use when opening a new log file:

    public StorageRandomAccessFile getRandomAccessFile( String mode) throws FileNotFoundException
        // Assume that modes "rws" and "rwd" are not supported.
        if(!rwsOK && "rws".equals( mode) || "rwd".equals( mode))
            mode = "rw";
        return new DirRandomAccessFile4( (File) this, mode);
    } // end of getRandomAccessFile

The expression in the if test is missing parentheses around the OR
expression making it return the wrong value for one case. If "rwd"
mode is requested for the file (and this is supported by the JVM), the
file is opened with "rw" instead of "rwd".

NOTE: this bug does not effect any current Derby versions since as far
as I know "rwd" is never used for log files. I came across it when
experimenting with using "rwd" for the log.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message