db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Army <qoz...@gmail.com>
Subject Re: [jira] Updated: (DERBY-1315) Statement optimization/compilation fails with OutOfMemoryException in largeCodeGen test with embedded and framework DerbyNetClient
Date Thu, 31 Aug 2006 20:47:26 GMT
Mike Matrigali wrote:
> 
> I don't think anyone has ever done performance and/or memory profiling 
> work against a "sane" system.  Effort is probably best spent elsewhere.

Good to know.  I guess the main reason I brought this up is because if we enable 
largeCodeGen to run as part of derbyall, people (such as myself) will inevitably 
try to run derbyall with SANE jars--and if they do so with 10,000 unions, 
they'll see an OOM error.  So if we add the 10,000 union query to the test, it 
seems like there'd have to be some logic to only run the test when running 
against an insane build...

<snip non-preferred way of building THROWASSERT strings>

> It is preferred that it be written as:
> 
> if (SanityManager.DEBUG)
> {
>     if (x != 0)
>     {
>         SanityManager.THROWASSERT("Incorrect offset." + ...
>     }
> }
> 
> The first instance can require the jvm to build the full string every
> execution, even when the assert does not fire.  The second will only
> build the string in the error case.

Ah, glad you pointed this out.  I myself usually do it the non-preferred way; 
this is something I'll have to look out for in the future...

Thanks for the feedback!
Army


Mime
View raw message