db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Korneliussen <Andreas.Kornelius...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-1387) Add JMX extensions to Derby
Date Mon, 21 Aug 2006 15:55:15 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sanket Sharma wrote:
> On 8/21/06, Andreas Korneliussen (JIRA) <derby-dev@db.apache.org> wrote:
>>    [
>> http://issues.apache.org/jira/browse/DERBY-1387?page=comments#action_12429432
>> ]
>>
>> Andreas Korneliussen commented on DERBY-1387:
>> ---------------------------------------------
>>
>> Hi, thanks for providing this patch. I have tried compiling it, and I
>> do have the following comments:
>>
>> 1. It seems that most of the classes have multiple entries in the
>> patch file, so when applying the patch, I got the same class multiple
>> times in the same file.
> 
> I'm not able to follow what you are trying to point out. Are you
> referring to the imports? Can you please explain so that I may look
> back at the patch and correct? This is the first time I've submitted
> anything using svn diff. Any help would be appriciated.
> 

The same file seems to be added multiple times in the patch file. I.e on
line 13 the class MBeanFactory is added:

Index: java/engine/org/apache/derby/iapi/services/mbeans/MBeanFactory.java
===================================================================
- --- java/engine/org/apache/derby/iapi/services/mbeans/MBeanFactory.java
(revision 0)
+++ java/engine/org/apache/derby/iapi/services/mbeans/MBeanFactory.java
(revision 0)
@@ -0,0 +1,161 @@


this is repeated in line 372:
Index: java/engine/org/apache/derby/iapi/services/mbeans/MBeanFactory.java
===================================================================
- --- java/engine/org/apache/derby/iapi/services/mbeans/MBeanFactory.java
(revision 0)
+++ java/engine/org/apache/derby/iapi/services/mbeans/MBeanFactory.java
(revision 0)
@@ -0,0 +1,161 @@


A possible reason, could be:
a, you did svn diff >> filename.diff instead of svn diff > filename.diff
b, my download is corrupt

Andreas

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (SunOS)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFE6ddi36DpyYjYNyIRApp8AJ0WfizxdQ/YvoNyvkTQSFQJdOQ9igCfZVGN
SZ16uxx2gI4C8HISjFqOaXY=
=ef2Q
-----END PGP SIGNATURE-----

Mime
View raw message