db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mamta A. Satoor (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1582) REVOKE statement does not generate a warning when no privileges are revoked.
Date Fri, 18 Aug 2006 21:46:15 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1582?page=comments#action_12429134 ] 
            
Mamta A. Satoor commented on DERBY-1582:
----------------------------------------

Deepa, your patch looks good to me. Just couple suggestion for the tests
1)You have some -ve test case for revoke table as follows
+-- This should raise warnings for bar
+revoke insert on satheesh.tsat from foo, bar;
+-- This should raise warnings for both foo and bar
+revoke insert on satheesh.tsat from foo, bar;

It will be nice to have similar -ve test case for revoke routine.. from mulitple users RESTRICT.
ie have couple users in single revoke routine and some or all of those users do not have the
privilege granted to them

2)I am not sure if you have tests for : When a privilege is found but it cannot be revoked
(cases like revoke privileges from database owner, self privilege revocation, revoke privilege
from object owner) 



> REVOKE statement does not generate a warning when no privileges are revoked.
> ----------------------------------------------------------------------------
>
>                 Key: DERBY-1582
>                 URL: http://issues.apache.org/jira/browse/DERBY-1582
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.0
>            Reporter: Daniel John Debrunner
>         Assigned To: Deepa Remesh
>         Attachments: d1582_v1.diff, d1582_v1.status, d1582_v2.diff, d1582_v2.status
>
>
> SQL 2003 standard, section 12.7 <revoke statement>, item 17 under general rules
indicates the statement completes with the condition 'warning ? privilege not revoked.' when
no matching privilege is revoked.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message