db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "A B (JIRA)" <derby-...@db.apache.org>
Subject [jira] Updated: (DERBY-1633) Regression: The fields of views are not being calculated properly since 10.1.2.4
Date Fri, 11 Aug 2006 18:14:14 GMT
     [ http://issues.apache.org/jira/browse/DERBY-1633?page=all ]

A B updated DERBY-1633:
-----------------------

    Attachment: d1633_v2.patch
                DERBY-1633_v2.html

Attaching a second version of the patch, d1633_v2.patch, that  addresses the regression described
in this issue.  Also attaching a second version of the HTML file that answers my previous
questions based on tracing and exploration of the code (relevant comments are also in the
code).

Differences between v1 and v2:

-- "RESOLVE" comments replaced with comments explaining the relevant pieces of code.

-- Fixed a problem in Predicate.isJoinPredicate() so that the method will only return true
if the predicate operands reference different tables (ex. T1.j = T1.i is not a join predicate).
 The need for this was exposed by the other changes for this issue and this small (2-line)
change was required to get the predicatePushdown test to run cleanly.

-- Added minor special-case logic to catch situations where predicates don't reference base
tables; see code comments for more.

-- Added a set of new tests to lang/predicatePushdown.sql and updated the master file accordingly.

Note that over half of this patch is from the new tests, and a good chunk of what's left is
comments, so the patch isn't actually all that big.

I ran derbyall on Red Hat Linux with ibm142 against SANE jars and saw no new failures.

This patch, d1633_v2.patch, is ready for review/commit.

> Regression: The fields of views are not being calculated properly since 10.1.2.4
> --------------------------------------------------------------------------------
>
>                 Key: DERBY-1633
>                 URL: http://issues.apache.org/jira/browse/DERBY-1633
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.1.3.0, 10.1.3.1
>         Environment: 2.8 GHZ dual PIV on Windows XP SP2, 2 GB memory
>            Reporter: Prasenjit Sarkar
>         Assigned To: A B
>             Fix For: 10.2.0.0
>
>         Attachments: d1633_repro.sql, d1633_v1_reviewOnly.patch, d1633_v2.patch, DERBY-1633_v1.html,
DERBY-1633_v2.html
>
>
> Database can be assumed to be same as in Derby - 1205 Jira issue
> SELECT PORT1.PORT_ID FROM T_RES_PORT PORT1, T_VIEW_ENTITY2PORT ENTITY2PORT WHERE ENTITY2PORT.PORT_ID
= PORT1.PORT_ID
> This works fine in 10.1.2.1 but fails thereafter complaining that Comparison between
INTEGER and CHAR is not supported
> for some reason, it thinks one of the PORT_ID columns is a character, when in reality
both are integers.
> 		SELECT DISTINCT 
> 		    ZONE.ZONE_ID ZONE_ID, 
> 			 PORT2ZONE.ZONE_MEMBER_ID  
> 		FROM  
> 			 T_RES_ZONE ZONE left outer join T_VIEW_PORT2ZONE PORT2ZONE on  
> 			 ZONE.ZONE_ID = PORT2ZONE.ZONE_ID   ,  T_RES_FABRIC FABRIC 
> In this query, it is complaining that one of the columns is a VARCHAR and cannot be compared
to INTEGER, when clearly this is not the case...
> Same issue

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message