Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: neutral (asf.osuosl.org: local policy)
Message-ID: <44BD83BF.1000806@sbcglobal.net>
Date: Tue, 18 Jul 2006 17:58:39 -0700
From: Kathey Marsden <kmarsdenderby@sbcglobal.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.7.13) Gecko/20060414
MIME-Version: 1.0
To: derby-dev@db.apache.org
Subject: DDMWriter - MAX_MARKS_NESTING - Is 10 high enough?
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


I am working on an issue where the following exception occured  after a 
long 16hr  stress run.  I don't have enough to file a bug yet and don't 
have line numbers but thought I would throw this out there as a start.   
Looking at the code I see think it might be related to MAX_MARKS_NESTING.
Looking at EXCSQLSTT it seems it could have up to 20 optional or 
required parameters.  I don't know that Network Server will ever seend 
that many.  I am collecting more information and trying to get a 
reproducible case, but I was curious about MAX_MARKS_NESTING and if it 
needs to be larger than 10.


Here is the information:

THE TRACE after 16 hour run

java.lang.ArrayIndexOutOfBoundsException
 at org.apache.derby.impl.drda.DDMWriter.startDdm(Unknown Source)
 at org.apache.derby.impl.drda.DRDAConnThread.writeSQLCARD(Unknown Source)
 at org.apache.derby.impl.drda.DRDAConnThread.writeSQLCARDs(Unknown Source)
 at org.apache.derby.impl.drda.DRDAConnThread.writeSQLCARDs(Unknown Source)
 at org.apache.derby.impl.drda.DRDAConnThread.checkWarning(Unknown Source)
 at org.apache.derby.impl.drda.DRDAConnThread.parseEXCSQLSTT(Unknown Source)
 at org.apache.derby.impl.drda.DRDAConnThread.processCommands(Unknown 
Source)M


COMMENT FOR  MAX_MARKS_NESTING in DDMWriter

// number of nesting levels for collections.  We need to mark the length
// location of the collection so that we can update it as we add more stuff
// to the collection

    private final static int MAX_MARKS_NESTING = 10;


CODE FOR startDdm
And the code for startDdm. I suspect top has exceeded 10. I  suppose it 
could be offset for bytes, but the ensurelength(4) seems like it should 
take care of that.

protected void startDdm (int codePoint)
    {
        // save the location of the beginning of the collection so
        // that we can come back and fill in the length bytes
        markStack[top++] = offset;
        ensureLength (4); // verify space for length bytes and code point
        offset += 2; // move past the length bytes before writing the 
code point
        bytes[offset] = (byte) ((codePoint >>> 8) & 0xff);
        bytes[offset + 1] = (byte) (codePoint & 0xff);
        offset += 2;
    }