db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunitha Kambhampati (JIRA)" <derby-...@db.apache.org>
Subject [jira] Updated: (DERBY-1227) Network Server should not use the underlying embedded prepared statement when accessing a BrokeredPreparedStatement
Date Thu, 20 Jul 2006 21:47:15 GMT
     [ http://issues.apache.org/jira/browse/DERBY-1227?page=all ]

Sunitha Kambhampati updated DERBY-1227:
---------------------------------------

    Attachment: 10.1_p1_derby1227.diff.txt

I would like the changes related to this fix to be backported to 10.1

The changes that went into trunk are a straight merge given by the merge commands below. But
there is another change required in 10.1 branch, one redundant line needs to be removed in
10.1. Note, that this line is not there in the trunk version of DRDAConnThread. 

I am attaching a patch 10.1_p1_derby1227.diff.txt for this one line change in DRDAConnThread
to keep this separate and simple. Only after this patch is applied, the below merge commands
should be used to backport the derby1227 trunk changes.

svn merge -r 421434:421435 https://svn.apache.org/repos/asf/db/derby/code/trunk/ 
svn merge -r 421459:421460 https://svn.apache.org/repos/asf/db/derby/code/trunk/ 

10.1_p1_derby1227.diff.txt is independent of the changes that are given by the merge commands.
This is a server only change. Ran derbynetclientmats and derbynetmats OK on linux/ibm142.

With 10.1_p1_derby1227.diff.txt and the merged changes, ran derbyall on linux/ibm142 OK.

Can someone please commit these changes.

Thanks,
Sunitha.

> Network Server should not use the underlying embedded prepared statement when accessing
a BrokeredPreparedStatement
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1227
>                 URL: http://issues.apache.org/jira/browse/DERBY-1227
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Server
>    Affects Versions: 10.1.2.1
>            Reporter: Kathey Marsden
>         Assigned To: Sunitha Kambhampati
>             Fix For: 10.2.0.0
>
>         Attachments: 10.1_p1_derby1227.diff.txt
>
>
> Network Server should not use the underlying embedded 
> Prepared statement when accessing a BrokeredPreparedStatement.
> In DERBY-1025 Dan pointed out this code which while not related to DERBY-1025 does appear
to be a problem. Here is his comment regarding this code in DRDAStatement:
>  /**
> * Get prepared statement
> *
> * @return prepared statement
> */
> protected PreparedStatement getPreparedStatement() throws SQLException
> {
> if (ps instanceof BrokeredPreparedStatement)
> return (PreparedStatement)(
> ((BrokeredPreparedStatement) ps).getStatement());
> else
> return ps;
> }
> This code, for some unknown reason due to lack of comments, is getting the underlying
embedded statement
> from a BrokeredPreparedStatement. This should not be allowed, the BrokeredStatement wrappers
are there to
> hide the embedded statement object as it can change under the covers of the wrapper.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message