db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@apache.org>
Subject Re: [jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.
Date Mon, 24 Jul 2006 23:54:27 GMT
Army wrote:


> **** Nit-picking: Changes that you don't *have* to do but that might
> help in cleaning up the patch.
> 
> A. Unnecessary white-space changes?

+1 to avoiding such changes.


> In SelectNode.java:
> 
> -              VerifyAggregateExpressionsVisitor visitor =
> -                  new VerifyAggregateExpressionsVisitor(groupByList);
> +            VerifyAggregateExpressionsVisitor visitor =
> +                new VerifyAggregateExpressionsVisitor(groupByList);
>              resultColumns.accept(visitor);


White space changes like this make it extra work on the reviewers. Is it
really just white space change or is there some minor change in there
that they need to be concerned about. Looking at such changes makes me
go cross-eyed as I try to determine if the lines are the same or not.

Thanks,
Dan.



Mime
View raw message