db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-815) Prevent unneeded object creation and excessive decoding in parseSQLDTA_work()
Date Wed, 26 Jul 2006 03:12:14 GMT
    [ http://issues.apache.org/jira/browse/DERBY-815?page=comments#action_12423509 ] 
            
Kathey Marsden commented on DERBY-815:
--------------------------------------

I am looking at this patch and have a couple of general questions

1)  I see that Bernt committed the original patch but I am having a hard time finding his
original review comments in the mail archives.   Are there comments from the initial review
that I could refer to?

2) I was wondering about the logic DRDAConnThread.java
I was wonding if it might be possible to work this so that CliParam does not have to be exposed
in DRDAConnThread? e.g just have a stmt.initCliParam(drdaType, drdaLength) that has all of
this logic in it.

final boolean haveParams = (stmt.getNumParams() > 0);
[....]
if (!haveParams) {				
// The statement has not been executed
// before so a new CliParam object
// must be added for each parameter
stmt.addCliParam(drdaType, drdaLength);
	continue;
	}
	// This statement has been executed before
	// so we reuse the CliParam objects (to
	// save some cycles)
	final DRDAStatement.CliParam cp = 
			stmt.getCliParam(j);
			// Clear out all info about the old
			// parameter and add info about the new one
			cp.init(drdaType, drdaLength);
		}


> Prevent unneeded object creation and excessive decoding in parseSQLDTA_work()
> -----------------------------------------------------------------------------
>
>                 Key: DERBY-815
>                 URL: http://issues.apache.org/jira/browse/DERBY-815
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server, Performance
>    Affects Versions: 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1, 10.1.3.0, 10.1.2.2,
10.0.2.2
>            Reporter: Knut Anders Hatlen
>         Assigned To: Dyre Tjeldvoll
>            Priority: Minor
>             Fix For: 10.2.0.0
>
>         Attachments: d815_regress.diff, d815_regress.java, derby-815.diff, derby-815.html,
derby-815.v3.diff, derby-815.v3.html, derby-815.v3.stat, derby-815.v4.diff, derby-815.v4.stat,
derby-815_2.diff, derbyall_report.v4.txt, derbyall_report_with_jdk1.4.v3.txt
>
>
> Reported by Kathey Marsden in DERBY-212:
> In reviewing the Network Server Code and profiling there were several
> areas that showed potential for providing performance
> improvement. Functions that need optimizing to prevent unneeded object
> creation and excessive decoding: parseSQLDTA_work()

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message