db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunitha Kambhampati (JIRA)" <derby-...@db.apache.org>
Subject [jira] Resolved: (DERBY-1227) Network Server should not use the underlying embedded prepared statement when accessing a BrokeredPreparedStatement
Date Fri, 14 Jul 2006 17:53:15 GMT
     [ http://issues.apache.org/jira/browse/DERBY-1227?page=all ]

Sunitha Kambhampati resolved DERBY-1227.
----------------------------------------

    Resolution: Fixed

This issue is fixed with the changes I made for DERBY-1015 , derby1015.diff.txt.  The changes
have been checked into trunk. 
URL: http://svn.apache.org/viewvc?rev=421435&view=rev
URL: http://svn.apache.org/viewvc?rev=421460&view=rev


> Network Server should not use the underlying embedded prepared statement when accessing
a BrokeredPreparedStatement
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1227
>                 URL: http://issues.apache.org/jira/browse/DERBY-1227
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Server
>    Affects Versions: 10.1.2.1
>            Reporter: Kathey Marsden
>         Assigned To: Sunitha Kambhampati
>             Fix For: 10.2.0.0
>
>
> Network Server should not use the underlying embedded 
> Prepared statement when accessing a BrokeredPreparedStatement.
> In DERBY-1025 Dan pointed out this code which while not related to DERBY-1025 does appear
to be a problem. Here is his comment regarding this code in DRDAStatement:
>  /**
> * Get prepared statement
> *
> * @return prepared statement
> */
> protected PreparedStatement getPreparedStatement() throws SQLException
> {
> if (ps instanceof BrokeredPreparedStatement)
> return (PreparedStatement)(
> ((BrokeredPreparedStatement) ps).getStatement());
> else
> return ps;
> }
> This code, for some unknown reason due to lack of comments, is getting the underlying
embedded statement
> from a BrokeredPreparedStatement. This should not be allowed, the BrokeredStatement wrappers
are there to
> hide the embedded statement object as it can change under the covers of the wrapper.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message