db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1527) Factor out type checks in EmbedResultSet and EmbedPreparedStatement
Date Thu, 20 Jul 2006 09:40:14 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1527?page=comments#action_12422375 ] 
            
Kristian Waagan commented on DERBY-1527:
----------------------------------------

I reviewed the patch, and it looks ready for commit.

The patch applies, no build failures, and I ran the jdbc40 suite as a sanity check (no failures
for embedded).

Do we have any tests for checking which set/update-methods can be used on the various datatypes?
If not, we ought to create a Jira for making one.


Thank you for doing this clean-up.

> Factor out type checks in EmbedResultSet and EmbedPreparedStatement
> -------------------------------------------------------------------
>
>                 Key: DERBY-1527
>                 URL: http://issues.apache.org/jira/browse/DERBY-1527
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.2.0.0
>            Reporter: Knut Anders Hatlen
>         Assigned To: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: derby-1527-v1.diff, derby-1527-v1.stat
>
>
> EmbedPreparedStatement and EmbedResultSet have many occurrences of
>     switch (...) {
>         case Types.CHAR:
>         case Types.VARCHAR:
>         case Types.LONGVARCHAR:
>         case Types.CLOB:
>             break;
>         default:
>             throw dataTypeConversion(...);
>     }
> and
>     switch (...) {
>         case Types.BINARY:
>         case Types.VARBINARY:
>         case Types.LONGVARBINARY:
>         case Types.BLOB:
>             break;
>         default:
>             throw dataTypeConversion(...);
>     }
> Instead of having many copies of this code, it would be good to factor
> it out into methods that can be shared. For instance, one could add
> these methods to DataTypeDescriptor:
>   public static boolean isAsciiStreamCompatible(int jdbcType)
>   public static boolean isBinaryStreamCompatible(int jdbcType)
>   public static boolean isCharacterStreamCompatible(int jdbcType)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message