db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-813) Clean up coding error in searchClauseTransitiveClosure method in PredicateList.java
Date Mon, 24 Jul 2006 23:24:14 GMT
    [ http://issues.apache.org/jira/browse/DERBY-813?page=comments#action_12423193 ] 
            
Kathey Marsden commented on DERBY-813:
--------------------------------------

I do not really understand the functional impact of this issue, so don't know if it is good
to target for 10.2 or not and would appreciate input on what the user  impact might be.



> Clean up coding error in searchClauseTransitiveClosure method in PredicateList.java
> -----------------------------------------------------------------------------------
>
>                 Key: DERBY-813
>                 URL: http://issues.apache.org/jira/browse/DERBY-813
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 10.0.2.0
>         Environment: generic
>            Reporter: Satheesh Bandaram
>            Priority: Minor
>             Fix For: 10.2.0.0
>
>
> I am separating this part of the bug from DERBY-808. This part of the fix can go into
10.2 release, while I would like to submit the first part of DERBY-808 to both 10.1 and trunk
branches.
> Coding error in PredicateList.searchClauseTransitiveClosure. Also note, when the operands
are switched, the type of the operation needs to change. For example, <ConstantNode>
<LessThan> <ColumnReference> should change to <ColumnReference> <GreaterThan>
<Constant>. Current code doesn's seem to do that either.
>     if (left instanceof ColumnReference && right instanceof ConstantNode) 
>     { 
>            searchClauses.addElement(predicate); 
>     } 
>     else if (right instanceof ConstantNode && left instanceof ColumnReference)

>     { 
>            // put the ColumnReference on the left to simplify things 
>            bcon.swapOperands(); 
>            searchClauses.addElement(predicate); 
>     } 
> The second part of the check is incorrect. It should instead be like: 
>    else if (left instanceof ConstantNode && right instanceof ColumnReference)

> and while handling ParameterNodes. Also the swaping logic is not complete.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message