db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1320) Test lang/procedure.java fails with ibm1.5 jvm
Date Thu, 27 Jul 2006 07:20:15 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1320?page=comments#action_12423783 ] 
Knut Anders Hatlen commented on DERBY-1320:

Hi Manjula,

Does your editor automatically strip trailing white-space when you
save a file? There are quite a number of pure white-space changes in
the patch. I think I found five lines where the code was changed, yet
the patch had 900 lines. Do you think you could regenerate the patch
with the necessary code changes only?

As to the changes I found, I don't think the first rs.next() in
testImplicitClose() should be commented out. It is there to make sure
all the rows are actually sent from the server. The purpose of the
test is to test that the result set is not closed on the server, even
when all rows have been sent. I should probably have documented this
better in the comments when I wrote the test.

If I understand this issue correctly, just adding rs.next() after
stmt.executeUpdate() should be enough, and it wouldn't change what is
tested. It would also be good to have a comment explaining why the
second rs.next() is needed, as it is not obvious.

One final nit. I don't think it is necessary or makes the code clearer
to split
  ResultSet rs = cs.getResultSet();
  ResultSet rs = null;
  // ResultSet
  rs = cs.getResultSet();
If it is not needed, I think it would be better to leave it as it is.

Knut Anders

> Test lang/procedure.java fails with ibm1.5 jvm
> ----------------------------------------------
>                 Key: DERBY-1320
>                 URL: http://issues.apache.org/jira/browse/DERBY-1320
>             Project: Derby
>          Issue Type: Test
>          Components: Test, Regression Test Failure
>    Affects Versions:
>         Environment: IBM 1.5 JVM /linux 
>            Reporter: Sunitha Kambhampati
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For:
>         Attachments: procedure.diff, procedure.diff, procedure.java, procedure.stat
> lang/procedure.java fails on IBM1.5 jvm on linux machine.    I spoke to Manjula who filed
DERBY-1108 that this is related to that issue and is a JVM bug. The JVM team has been notified.
   Please note: I have marked this as a Regression Test Failure although this test has not
passed with IBM 1.5 JVM atleast in our nightly regression test runs,  so it is not a regression
of the product. 
> diff:
> ********* Diff file derbyall/derbylang/procedure.diff
> *** Start: procedure jdk1.5.0 derbyall:derbylang 2006-05-10 22:17:16 ***
> 1018 del
> < testImplicitClose(): PASSED
> 1018 add
> > testImplicitClose(): FAILED (no exception thrown)
> Test Failed.
> *** End:   procedure jdk1.5.0 derbyall:derbylang 2006-05-10 22:17:31 ***
> here is machine info.
> ------------------ Java Information ------------------
> Java Version:    1.5.0
> Java Vendor:     IBM Corporation
> Java home:       /local1/cloudtst/dev/src/ibm15/jre
> Java classpath:  /local1/cloudtst/dev/src/jars/insane/derby.jar:/local1/cloudtst/dev/src/jars/insane/derbytools.jar:/local1/cloudtst/dev/src/jars/insane/derbynet.jar:/local1/cloudtst/dev/src/jars/insane/derbyclient.jar:/local1/cloudtst/dev/src/jars/insane/derbyTesting.jar:/local1/cloudtst/dev/src/jcc/db2jcc.jar:/local1/cloudtst/dev/src/jcc/db2jcc_license_c.jar:/local1/cloudtst/dev/src/jars/insane/derbyTesting.jar:/local1/cloudtst/dev/src/tools/java/jakarta-oro-2.0.8.jar:/local1/cloudtst/dev/src/tools/java/junit.jar:/local1/cloudtst/dev/src/jars/insane/derbyLocale_de_DE.jar:/local1/cloudtst/dev/src/jars/insane/derbyLocale_es.jar:/local1/cloudtst/dev/src/jars/insane/derbyLocale_fr.jar:/local1/cloudtst/dev/src/jars/insane/derbyLocale_it.jar:/local1/cloudtst/dev/src/jars/insane/derbyLocale_ja_JP.jar:/local1/cloudtst/dev/src/jars/insane/derbyLocale_ko_KR.jar:/local1/cloudtst/dev/src/jars/insane/derbyLocale_pt_BR.jar:/local1/cloudtst/dev/src/jars/insane/derbyLocale_zh_CN.jar:/local1/cloudtst/dev/src/jars/insane/derbyLocale_zh_TW.jar:/local1/cloudtst/dev/src/jars/insane/derbyrun.jar:
> OS name:         Linux
> OS architecture: x86
> OS version:      2.6.5-7.252-bigsmp
> Java user name:  cloudtst
> Java user home:  /u/cloudtst
> Java user dir:   /local1/cloudtst/dev/src/NightlyBuildResults.2006-05-10/ibm15_derbyall
> java.specification.name: Java Platform API Specification
> java.specification.version: 1.5
> --------- Derby Information --------
> JRE - JDBC: J2SE 5.0 - JDBC 3.0
> [/local1/cloudtst/dev/src/jars/insane/derby.jar] alpha - (405653)
> [/local1/cloudtst/dev/src/jars/insane/derbytools.jar] alpha - (405653)
> [/local1/cloudtst/dev/src/jars/insane/derbynet.jar] alpha - (405653)
> [/local1/cloudtst/dev/src/jars/insane/derbyclient.jar] alpha - (405653)
> [/local1/cloudtst/dev/src/jcc/db2jcc.jar] 2.6 - (90)
> [/local1/cloudtst/dev/src/jcc/db2jcc_license_c.jar] 2.6 - (90)
> ------------------------------------------------------

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message