db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "V.Narayanan (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-694) Statement exceptions cause all the connection's result sets to be closed with the client driver
Date Wed, 19 Jul 2006 08:00:14 GMT
    [ http://issues.apache.org/jira/browse/DERBY-694?page=comments#action_12422052 ] 
V.Narayanan commented on DERBY-694:

Thanks a ton for the comments and reviews. 

1) Will add the test case in a fresh patch

2) Yes uwl.completeLocalRollback() should be called in all the places. Removing it from the
Map alone would'nt suffice. Thank you for catching this.

3) instead of replicating logic for ResultSets as well as Statements if I push the try catch
to where we parse the ABNUOWRM we can avoid replicating.

4) NetConnectionReply.parseAbnormalEndUow(StatementCallbackInterface statement) statement
is not necessary. Will remove this.

I will add a test case and also address all the issues pointed out and submit a fresh patch.

thanx again, 

> Statement exceptions cause all the connection's result sets to be closed with the client
> -----------------------------------------------------------------------------------------------
>                 Key: DERBY-694
>                 URL: http://issues.apache.org/jira/browse/DERBY-694
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client
>    Affects Versions:
>            Reporter: Oyvind Bakksjo
>         Assigned To: V.Narayanan
>            Priority: Minor
>         Attachments: DERBY-694.html, DERBY-694_upload_v1.diff, DERBY-694_upload_v1.stat,
> Scenario:
> Autocommit off. Have two prepared statements, calling executeQuery() on both, giving
me two result sets. Can fetch data from both with next(). If one statement gets an exception
(say, caused by a division by zero), not only this statement's result set is closed, but also
the other open resultset. This happens with the client driver, whereas in embedded mode, the
other result set is unaffected by the exception in the first result set (as it should be).

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message