Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 23098 invoked from network); 22 Jun 2006 14:11:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Jun 2006 14:11:47 -0000 Received: (qmail 48304 invoked by uid 500); 22 Jun 2006 14:11:46 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 48279 invoked by uid 500); 22 Jun 2006 14:11:46 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 48270 invoked by uid 99); 22 Jun 2006 14:11:46 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jun 2006 07:11:46 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=UNPARSEABLE_RELAY X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.18.42.249] (HELO nwkea-pix-1.sun.com) (192.18.42.249) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jun 2006 07:11:45 -0700 Received: from d1-sfbay-10.sun.com ([192.18.39.120]) by nwkea-pix-1.sun.com (8.13.6+Sun/8.12.9) with ESMTP id k5MEBOp5000667 for ; Thu, 22 Jun 2006 07:11:24 -0700 (PDT) Received: from conversion-daemon.d1-sfbay-10.sun.com by d1-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) id <0J1900I01M1N9Q00@d1-sfbay-10.sun.com> (original mail from Richard.Hillegas@Sun.COM) for derby-dev@db.apache.org; Thu, 22 Jun 2006 07:11:24 -0700 (PDT) Received: from [129.150.20.46] by d1-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) with ESMTPSA id <0J1900BW9M30A030@d1-sfbay-10.sun.com> for derby-dev@db.apache.org; Thu, 22 Jun 2006 07:11:24 -0700 (PDT) Date: Thu, 22 Jun 2006 07:11:24 -0700 From: Rick Hillegas Subject: Re: ADVICE REQUESTED: Fixing MessageBundleTest In-reply-to: <4499DD2C.2060004@sun.com> Sender: Richard.Hillegas@Sun.COM To: derby-dev@db.apache.org Message-id: <449AA50C.3030703@sun.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT X-Accept-Language: en-us, en References: <4499C7BD.8040602@sun.com> <4499DBFC.9010203@apache.org> <4499DD2C.2060004@sun.com> User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi David, You might want to wrap the test in a custom Ant Task. These are described in the Ant manual: "Developing with Ant"->"Writing Your Own Task". You can then check the return status of the task and fail the build if appropriate. Regards, -Rick David Van Couvering wrote: > Hm, a build-time check. I guess in a way it is a build-time issue. > Let me think about how I might do that, thanks for the idea. > > David > > Daniel John Debrunner wrote: > >> David Van Couvering wrote: >> >>> So, as Andrew very astutely pointed out, i18n/MessageBundleTest.java >>> will not succeed when running against the jar files because it tries to >>> load shared/common/reference/SQLState, which is not included in the jar >>> files. This problem also exists for MessageId.java, which this test >>> also refers to and which also is not included in the jar files. >> >> >> Does this need to be a test, could it be converted into a build time >> check? Then there are no requirements for these classes to be in >> derbytesting.jar. Also there is probably no requirement to run this test >> on different platforms. >> >> I used to have something similar (pre-open source), that found messages >> that existed but were never used. >> >> Dan. >>