Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <4485E67A.8050004@amberpoint.com>
Date: Tue, 06 Jun 2006 13:32:58 -0700
From: Bryan Pendleton <bpendleton@amberpoint.com>
User-Agent: Thunderbird 1.5.0.4 (Windows/20060516)
MIME-Version: 1.0
To: derby-dev@db.apache.org
Subject: Re: [jira] Commented: (DERBY-1326) Network server may abandon
 sessions
 when Derby system is shutdown and this causes intermittent hangs in the
 client
References: <8614858.1149551551019.JavaMail.jira@brutus>
In-Reply-To: <8614858.1149551551019.JavaMail.jira@brutus>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

> Deepa Remesh commented on DERBY-1326:
> -------------------------------------
> 
> I applied 'resolve_DRDConnThread_conflict.diff' and ran the repro 50 times without any hang.

Thanks very much for all the careful reviews and help!

I am hopeful that some other reviewers can take a look at these changes,
as I think they are pretty subtle and could use as much review as they can get.

Meanwhile, here's some of the things I plan to do:
  - I have run derbyall successfully
  - I, too, have run the various repros without any hang
  - I will update the patch to reflect your most recent comments about
    fixing the whitespace and adding some more comments
  - I intend to revisit the NetworkServerSessionManagement wiki page
    and update it to reflect the decisions that we have made during
    the work on this bug

Lastly, do you think that we need to convert your repro1326 into a new
test program? Or do you think that the checkDataSource and checkDataSource30
tests are adequate for now? If we want to add the new code as a test case,
should we add it to the checkDataSource program? Or somewhere else?

thanks,

bryan