Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 73814 invoked from network); 6 Jun 2006 21:58:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Jun 2006 21:58:33 -0000 Received: (qmail 88694 invoked by uid 500); 6 Jun 2006 21:58:32 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 88656 invoked by uid 500); 6 Jun 2006 21:58:32 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 88647 invoked by uid 99); 6 Jun 2006 21:58:32 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2006 14:58:32 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2006 14:58:31 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 97BD17142A1 for ; Tue, 6 Jun 2006 21:57:30 +0000 (GMT) Message-ID: <11958254.1149631050618.JavaMail.jira@brutus> Date: Tue, 6 Jun 2006 21:57:30 +0000 (GMT+00:00) From: "Halley Pacheco de Oliveira (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-1376) File java/engine/org/apache/derby/loc/messages_en.properties - Message XSLAT.D In-Reply-To: <20915566.1149512970162.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/DERBY-1376?page=comments#action_12415058 ] Halley Pacheco de Oliveira commented on DERBY-1376: --------------------------------------------------- Hi Suresht, Reading the text of the message I couldn't devise the concern about the directory belonging to other database. By this reason, I liked what David Van Couvering wrote in Derby Developers discussion list (Re: DERBY-1376 - Text for exceptions - File java/engine/org/apache/derby/loc/messages_en.properties): "At one project in Sun you actually had an API that *required* you to provide the error messages, the probable cause, and a recommended course of action as three separate messages." Using this guideline for writing error messages, the message could be: Error message: Log directory {0} exists. Probable cause: Maybe the directory belongs to other database. Recommended course of action: Make sure specified logDevice location is correct. So, using this guideline what is missing in the text of the message is the probable cause. halley > File java/engine/org/apache/derby/loc/messages_en.properties - Message XSLAT.D > ------------------------------------------------------------------------------ > > Key: DERBY-1376 > URL: http://issues.apache.org/jira/browse/DERBY-1376 > Project: Derby > Type: Improvement > Components: Localization > Versions: 10.1.2.4 > Environment: Text for exceptions > Reporter: Halley Pacheco de Oliveira > Priority: Minor > Fix For: 10.1.2.4 > > The message XSLAT.D (String LOG_SEGMENT_EXIST = "XSLAT.D";) states: > XSLAT.D=Log directory {0} exists. Please make sure specified logDevice location is correct. > But it seems by the source code that the problem is not that this directory exists, but the fact that it is not empty (// make sure log directory is empty, in LogToFile.java). So it seems to me that the following message would be better: > XSLAT.D=Log directory {0} is not empty. Please make sure specified logDevice location is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira