db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John H. Embretsen" <John.Embret...@Sun.COM>
Subject Re: [jira] Updated: (DERBY-1379) NIST tests fail on jdk16 after introduction of JDBC4 driver autoloading
Date Thu, 08 Jun 2006 10:55:38 GMT
Olav Sandstaa (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/DERBY-1379?page=all ]
> 
> Olav Sandstaa updated DERBY-1379:
> ---------------------------------
> 
>     Attachment: autoload.diff
> 
> This patch solves the problem with running the Nist tests under jdk
> 1.6 by unloading the embedded driver before the nist suite is started. 

[SNIP]

> The patch is ready for review and commit. I would like to get feedback
> on:
> 
>  1. The selected approach for solving this problem (by explicitly
>     unload the embedded driver).

For what it's worth, I think you picked the best approach, at least for 
now. Test suites should not depend on each other, so I think it is 
healthy to unload the embedded driver first, now that "automagic" things 
start interfering with our aging test harness.

>  2. If the code for unload the driver is included in the test harness
>     on the most appropriate place.

Seems good to me... (but I'm no expert in this area)


-- 
John


Mime
View raw message