db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1445) Add new streaming overloads and modify some existing ones.
Date Fri, 23 Jun 2006 14:05:32 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1445?page=comments#action_12417495 ] 

Knut Anders Hatlen commented on DERBY-1445:
-------------------------------------------

Hi Narayanan,

It seems like your editor has eight character tabs, so your
indentation doesn't always match the surrounding code. For instance,
the javadocs for EmbedResultSet.updateAsciiStream, updateBinaryStream
and updateCharacterStream are indented with four characters too much.

I also notice that several places the indentation is a mix of tabs and
spaces. For instance, in EmbedPreparedStatement you have

+    public final void setCharacterStream(int parameterIndex,
+       			  java.io.Reader reader,
+			  int length) throws SQLException {
+        setCharacterStream(parameterIndex,reader,(long)length);
+    }

First line is indented with spaces only.
Second line with spaces followed by tabs followed by spaces.
Third line with tabs followed by spaces.
Fourth line and fifth line are indented with spaces only.

Please check your tab setting (four characters) and try to keep the
indentation consistent (at least try to avoid mixing tabs and spaces
on the same line). Thanks!

>  Add new streaming overloads and modify some existing ones.
> -----------------------------------------------------------
>
>          Key: DERBY-1445
>          URL: http://issues.apache.org/jira/browse/DERBY-1445
>      Project: Derby
>         Type: New Feature

>   Components: JDBC
>     Reporter: V.Narayanan
>     Assignee: V.Narayanan
>  Attachments: JDBC40_long_length_overloads.diff, JDBC40_long_length_overloads.stat
>
> The task involves Adding and modifying the following methods 
>         add PreparedStatement.setAsciiStream (int columnIndex, InputStream x, long length)
>   	add PreparedStatement.setBinaryStream (int columnIndex, InputStream x, long length
>   	add PreparedStatement.setCharacterStream (int columnIndex, Reader x, long length)
>   	add CallableStatement.setAsciiStream (String columnName, InputStream x, long length)
>   	add CallableStatement.setBinaryStream (String columnName, InputStream x, long length)
>   	add CallableStatement.setCharacterStream (String columnName, Reader x, long length)
>   	add ResultSet.updateAsciiStream (int columnIndex, InputStream x, long length)
>   	add ResultSet.updateBinaryStream (int columnIndex, InputStream x, long length)
>   	add ResultSet.updateCharacterStream (int columnIndex, Reader x, long length)
>   	add ResultSet.updateAsciiStream (String columnName, InputStream x, long length)
>   	add ResultSet.updateBinaryStream (String columnName, InputStream x, long length)
>   	add ResultSet.updateCharacterStream (String columnName, Reader x, long length)
>   	add ResultSet.updateBlob (int columnIndex, InputStream x, long length)
>   	add ResultSet.updateBlob (String columnName, InputStream x, long length)
>   	add ResultSet.updateClob (int columnIndex, Reader x, long length)
>   	add ResultSet.updateClob (String columnName, Reader x, long length)
>   	add ResultSet.updateNClob (int columnIndex, Reader x, long length)
>   	add ResultSet.updateNClob (String columnName, Reader x, long length)
>   	modify ResultSet.updateNCharacterStream(int columnIndex, Reader x, int length) to
ResultSet.updateNCharacterStream(int columnIndex, Reader x, long
>         length)
>   	modify ResultSet.updateNCharacterStream(String columnName, Reader x, int length) to
ResultSet.updateNCharacterStream(String columnName, 
>         Reader x, long length)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message