Return-Path: 
 <derby-dev-return-21092-apmail-db-derby-dev-archive=db.apache.org@db.apache.org>
Delivered-To: apmail-db-derby-dev-archive@www.apache.org
Received: (qmail 49846 invoked from network); 26 May 2006 10:48:39 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 26 May 2006 10:48:39 -0000
Received: (qmail 33612 invoked by uid 500); 26 May 2006 10:48:38 -0000
Delivered-To: apmail-db-derby-dev-archive@db.apache.org
Received: (qmail 33579 invoked by uid 500); 26 May 2006 10:48:38 -0000
Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:derby-dev-help@db.apache.org>
List-Unsubscribe: <mailto:derby-dev-unsubscribe@db.apache.org>
List-Post: <mailto:derby-dev@db.apache.org>
List-Id: <derby-dev.db.apache.org>
Reply-To: <derby-dev@db.apache.org>
Delivered-To: mailing list derby-dev@db.apache.org
Received: (qmail 33570 invoked by uid 99); 26 May 2006 10:48:38 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 May 2006 03:48:38 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=UNPARSEABLE_RELAY
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Received: from [192.18.1.36] (HELO gmpea-pix-1.sun.com) (192.18.1.36)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 May 2006 03:48:37 -0700
Received: from d1-emea-10.sun.com (d1-emea-10.sun.com [192.18.2.120] (may be
 forged))
	by gmpea-pix-1.sun.com (8.12.9/8.12.9) with ESMTP id k4QAmGg5019519
	for <derby-dev@db.apache.org>; Fri, 26 May 2006 11:48:16 +0100 (BST)
Received: from conversion-daemon.d1-emea-10.sun.com by d1-emea-10.sun.com
 (Sun Java System Messaging Server 6.2-4.02 (built Sep  9 2005))
 id <0IZV00901CJI9400@d1-emea-10.sun.com>
 (original mail from Knut.Hatlen@Sun.COM) for derby-dev@db.apache.org; Fri,
 26 May 2006 11:48:16 +0100 (BST)
Received: from khepri19 ([129.159.112.231])
 by d1-emea-10.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep
  9
 2005)) with ESMTPSA id <0IZV00DUDCOEAO10@d1-emea-10.sun.com> for
 derby-dev@db.apache.org; Fri, 26 May 2006 11:48:16 +0100 (BST)
Date: Fri, 26 May 2006 12:48:14 +0200
From: Knut Anders Hatlen <Knut.Hatlen@Sun.COM>
Subject: Re: junit tests; get*DataSource* methods in BaseJDBCTestCase causing
 trouble...
In-reply-to: <c25576af0605260107t5efde155p9b26d666150f4b12@mail.gmail.com>
Sender: Knut.Hatlen@Sun.COM
To: derby-dev@db.apache.org
Message-id: <wjo8psi1f4ep.fsf@sun.com>
Organization: Sun Microsystems
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7BIT
References: <c25576af0605260107t5efde155p9b26d666150f4b12@mail.gmail.com>
User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.0.50 (usg-unix-v)
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Myrna van Lunteren <m.v.lunteren@gmail.com> writes:

> Hi,
> With revision 389780 some methods were added into BaseJDBCTestCase.java:
> "DERBY-1157: Helper methods in BaseJDBCTestCase for creating data sources
>
> Adding getDataSource(), getConnectionPoolDataSource() and
> getXADataSource() to BaseJDBCTestCase. The new methods call various
> methods in TestUtil for creating the data sources. A minor adjustment
> had to be made to TestUtil.getDataSource() in order to make it return
> JDBC 4.0 DataSources."
>
> However, this causes trouble with the j9 jvms. So, I need to move
> these methods back out of BaseJDBCTestCase.

Out of curiosity, what kind of trouble is it causing? If the method
signatures cause trouble when the class is loaded, why isn't that the
case for TestUtil?

> I can see 3 choices for their new home:
>
> - util/TestConfiguration.java
> - util/TestUtil.java
> - util/<a new utility class specially for junit tests but I cannot
> think of a good name>
>
> My personal preference goes to TestUtil.java, but that looks like it
> is at cross purposes with the contribution of 389780. Any input?

The methods don't add significant value, so I think it's OK to remove
them from BaseJDBCTestCase and let the JUnit tests use the
corresponding methods in TestUtil instead. If it is possible, we
should try to keep getDefaultDataSourceProperties().

-- 
Knut Anders