Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 66267 invoked from network); 11 May 2006 04:56:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 11 May 2006 04:56:30 -0000 Received: (qmail 24123 invoked by uid 500); 10 May 2006 21:49:50 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 24096 invoked by uid 500); 10 May 2006 21:49:49 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 24087 invoked by uid 99); 10 May 2006 21:49:49 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2006 14:49:49 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2006 14:49:49 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 35ACA7142BA for ; Wed, 10 May 2006 21:49:05 +0000 (GMT) Message-ID: <2111256.1147297745217.JavaMail.jira@brutus> Date: Wed, 10 May 2006 21:49:05 +0000 (GMT+00:00) From: "Daniel John Debrunner (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-684) Improve performance of Clob objects (ClobOutputStream#write,ClobWriter#write) on the client In-Reply-To: <892993015.1131156619900.JavaMail.jira@ajax.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/DERBY-684?page=comments#action_12378981 ] Daniel John Debrunner commented on DERBY-684: --------------------------------------------- Note that StringBufferInputStream is non-portable and should not be used. It will lead to different output on platforms with different default encoding, e.g. IBM z/os. See DERBY-1256 > Improve performance of Clob objects (ClobOutputStream#write,ClobWriter#write) on the client > ------------------------------------------------------------------------------------------- > > Key: DERBY-684 > URL: http://issues.apache.org/jira/browse/DERBY-684 > Project: Derby > Type: Improvement > Components: Performance, Network Client > Versions: 10.2.0.0, 10.1.1.1, 10.1.1.0 > Environment: all > Reporter: Sunitha Kambhampati > > Dan suggested this improvement here: > http://issues.apache.org/jira/browse/DERBY-463?page=comments#action_12356742 > For org.apache.derby.client.am.ClobOutputStream#write(int), five objects are created for every byte written. > "In fact this class and the client Clob have code like this everywhere, as the Clob is updated: > clob_.string_ = clob_.string_.concat(new String(newByte)); > clob_.asciiStream_ = new java.io.StringBufferInputStream(clob_.string_); > clob_.unicodeStream_ = new java.io.StringBufferInputStream(clob_.string_); > clob_.characterStream_ = new java.io.StringReader(clob_.string_); > Would probably be better to create most of those objects on demand, rather than on every modification. I mean if the CLOB is modified > but the application never retrieives the ascii or character streams, what was the benefit of creating them? " > ________________ > Also check the org.apache.derby.client.am.ClobWriter. Need to make this better and efficient. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira