Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 73257 invoked from network); 31 May 2006 19:19:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 31 May 2006 19:19:27 -0000 Received: (qmail 18980 invoked by uid 500); 31 May 2006 19:19:26 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 18941 invoked by uid 500); 31 May 2006 19:19:26 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 18927 invoked by uid 99); 31 May 2006 19:19:25 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 May 2006 12:19:25 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=UNPARSEABLE_RELAY X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.18.1.36] (HELO gmpea-pix-1.sun.com) (192.18.1.36) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 May 2006 12:19:24 -0700 Received: from d1-emea-09.sun.com ([192.18.2.119]) by gmpea-pix-1.sun.com (8.12.9/8.12.9) with ESMTP id k4VJJ24x026251 for ; Wed, 31 May 2006 20:19:02 +0100 (BST) Received: from conversion-daemon.d1-emea-09.sun.com by d1-emea-09.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) id <0J0500D019M69D00@d1-emea-09.sun.com> (original mail from Bernt.Johnsen@Sun.COM) for derby-dev@db.apache.org; Wed, 31 May 2006 20:19:02 +0100 (BST) Received: from localhost (180.80-203-115.nextgentel.com [80.203.115.180]) by d1-emea-09.sun.com (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) with ESMTPSA id <0J0500M1J9NOLL50@d1-emea-09.sun.com> for derby-dev@db.apache.org; Wed, 31 May 2006 20:19:02 +0100 (BST) Date: Wed, 31 May 2006 21:18:38 +0200 From: "Bernt M. Johnsen" Subject: Re: Code formatting debate, confusion and wasted time , Has it gone on long enough? In-reply-to: <447DA443.3000706@sbcglobal.net> Sender: Bernt.Johnsen@Sun.COM To: derby-dev@db.apache.org Message-id: <20060531191838.GB29296@localhost.localdomain> Organization: Sun Microsystems MIME-version: 1.0 Content-type: multipart/signed; boundary=St7VIuEGZ6dlpu13; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-disposition: inline References: <447DA443.3000706@sbcglobal.net> User-Agent: Mutt/1.5.9i X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --St7VIuEGZ6dlpu13 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I heartily agree. We definitely need an enforced standard on this. Personally, I don't care very much about coding style (whether the "{"'s are placed on separate lines or not, whether a function is falled "foo()" or "foo ()" etc). But I do very much care about whitespace problems when dealing with tools like cvs and svn.=20 And, we should definitely get rid of the tabs. >>>>>>>>>>>> Kathey Marsden wrote (2006-05-31 07:12:19): > In a comment in DERBY-1302 Knut Anders said .... > >If we want to reindent large parts of the code, I think we should do > >it sometime after 10.1.3 is released and before the 10.2 branch is > >created, and we should try to use a style that is used elsewhere in > >the code (I prefer tab-free code myself). >=20 > Perhaps we have all lived in the code formatting "Tower of Babel" long=20 > enough. I think code formatting like language doesn't matter as long as= =20 > everyone understands it and it is consistent. I would like to propose=20 > that we: >=20 > 1) Choose and document a format.=20 > I think everyone can agree to get rid of the tabs. Otherwise ... > The volunteer doing the work gets to propose the format and only=20 > very serious objections should be raised > in the interest of getting this done. Some Apache examples=20 > are at: > =20 > http://jakarta.apache.org/site/faqs.html#Coding%20Conventions%20and%20Sta= ndards > 2) Set a date six weeks out from the completion of the code formatting=20 > documentation for the reformat so folks can plan accordingly. > 3) See if there are volunteers willing to determine the correct settings= =20 > for Eclipse, Net Beans and other IDE's. > 4) On the reformatting date, reformat both the trunk and the 10.1 branch= =20 > so that fixes can be merged easily. >=20 > Extra credit, think about long term maintenance, checking, and=20 > auto-formatting. >=20 > Does anyone have any objections to a plan like this? If not I will=20 > create a Jira entry and subtasks. Anyone tired enough of this issue to=20 > take on this task? >=20 > Kathey >=20 > http://en.wikipedia.org/wiki/Tower_of_Babel >=20 >=20 --=20 Bernt Marius Johnsen, Database Technology Group,=20 Staff Engineer, Technical Lead Derby/Java DB Sun Microsystems, Trondheim, Norway --St7VIuEGZ6dlpu13 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFEfewOlFBD9TXBAPARAh5SAJ4zUtjC7sSAt8o9bPvpCXb2MsNBTgCcDgZ6 CdT+TtCYRivcSxx85y642IA= =02r0 -----END PGP SIGNATURE----- --St7VIuEGZ6dlpu13--