Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
Date: Thu, 04 May 2006 21:53:29 +0200
From: "Bernt M. Johnsen" <Bernt.Johnsen@Sun.COM>
Subject: Re: [jira] Commented: (DERBY-7) Bug in NULLIF Function
In-reply-to: <17536823.1146764847834.JavaMail.jira@brutus>
Sender: Bernt.Johnsen@Sun.COM
To: "Myrna van Lunteren (JIRA)" <derby-dev@db.apache.org>
Message-id: <20060504195329.GA19866@localhost.localdomain>
Organization: Sun Microsystems
MIME-version: 1.0
Content-type: multipart/signed; boundary="PEIAKu/WMn1b1Hv9";
 protocol="application/pgp-signature"; micalg=pgp-sha1
Content-disposition: inline
References: <979740866.1096332272139.JavaMail.apache@nagoya>
 <17536823.1146764847834.JavaMail.jira@brutus>
User-Agent: Mutt/1.5.9i


--PEIAKu/WMn1b1Hv9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

>>>>>>>>>>>> Myrna van Lunteren (JIRA) wrote (2006-05-04 17:47:27):
>     [ http://issues.apache.org/jira/browse/DERBY-7?page=3Dcomments#action=
_12377852 ]=20
>=20
> Myrna van Lunteren commented on DERBY-7:
> ----------------------------------------
>=20
> Hi Berndt,
>=20
> I happened to spot the following in your check-in for revision 399657 for=
 the test jdbcapi/resultset.java:
>=20
> +                               } catch(SQLException ex){
> +                                       if (ex.getSQLState().equals("2200=
5")) {
> +                                               if (s.getBytes (i) !=3D n=
ull)
> +                row.append(new String(s.getBytes(i)));
> +                                               else
> +                row.append(s.getBytes(i));
> +                                       } else throw ex;=20
> +                               }
>=20
> I think what has happened here is that you applied original patch of
> DERBY-7 to 10.1.

No, I did a
svn merge -r227280:227281 ../trunk

> However, the test resultset.java has since had some work done on it,
> and I'm specifically concerned that you may have missed the changes
> I worked on for DERBY-903, which were committed with revision 378337
> and 379643.

I think the explanation is that DERBY-7 was committed long before
DERBY-903, but now they were applied to 10.1 in the opposite order.

> This eliminates the use of the constructor 'new String(bytes[]),
> which is non-portable...It constructs a string by decoding the bytes
> using the default platform charset. This can lead to encoding
> related problems.  For this case, you should probably use the
> constructor that takes in the encoding. ie new String(byte[], String
> charsetname).
>=20
> Can you please rework this section of resultset.java to not use an
> encoding-safe mechanism?  Just compare with the current 10.2
> resultset.java...


Thanks for spotting this one, I'll look into it.

--=20
Bernt Marius Johnsen, Database Technology Group,=20
Staff Engineer, Technical Lead Derby/Java DB
Sun Microsystems, Trondheim, Norway

--PEIAKu/WMn1b1Hv9
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFEWlu5lFBD9TXBAPARAiU/AJ40+hQa5u9Q7FofnvKwKX7VJrihxgCdErTo
CDmGaSTr5fw05/zyq2s0Md8=
=byAo
-----END PGP SIGNATURE-----

--PEIAKu/WMn1b1Hv9--