[ http://issues.apache.org/jira/browse/DERBY-514?page=comments#action_12377918 ] 

Deepa Remesh commented on DERBY-514:
------------------------------------

updated patch7 looks good to me. I took a quick look at it and also tried running the upgrade suite. As before, I had to manually delete Upgrade_10_1_10_2_app.properties though I see that the file delete is specified in the diff file.

> Integrate upgrade tests into test suite
> ---------------------------------------
>
>          Key: DERBY-514
>          URL: http://issues.apache.org/jira/browse/DERBY-514
>      Project: Derby
>         Type: Test

>   Components: Test
>     Versions: 10.1.2.0, 10.2.0.0
>     Reporter: Kathey Marsden
>     Assignee: Deepa Remesh
>      Fix For: 10.2.0.0
>  Attachments: derby-514-buildfiles-v1.diff, derby-514-buildfiles-v1.status, derby-514-patch1-v1.diff, derby-514-patch1-v1.status, derby-514-patch2-runtest-v1.diff, derby-514-patch2-runtest-v1.status, derby-514-patch3-v1.diff, derby-514-patch3-v1.status, derby-514-patch3-v2.diff, derby-514-patch3-v2.status, derby-514-patch4-sed.diff, derby-514-patch4-sed.status, derby-514-patch5-addtoderbyall.diff, derby-514-patch5-addtoderbyall.status, derby-514-patch6-build_changes.diff, derby-514-patch6-build_changes.status, derby-514-patch7-andrew.diff, derby-514-patch7-v2.diff
>
> Currently there are no upgrade tests in the derbyAll suite.
> The upgrade tests java/testing/org/apache/derbyTesting are run by script and require that the version to be tested by specified on the command line so that the classpath can be changed.
> # runphases old_major old_minor old_engine new_engine
> #
> # e.g.
> #
> # runphases 10 0 c:/derby/10.0.2.1/lib c:/derby/trunk/jars/sane
> Perhaps this script can be rewritten in Java using class loaders and  previous Derby verssions such as 10.0 and 10.1 be checked in so that this testing can   be incorporated into the derbyAll test suite.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira