db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1347) derbynet/SuicideOfStreaming.java should not use internal class SqlCode
Date Thu, 25 May 2006 18:06:30 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1347?page=comments#action_12413281 ] 

Daniel John Debrunner commented on DERBY-1347:

I don't believe our error codes are published. I believe they should not be as it is a vendor
specific interface and encouraging applications to use them will result in non-portable applications.

> derbynet/SuicideOfStreaming.java should not use internal class SqlCode
> ----------------------------------------------------------------------
>          Key: DERBY-1347
>          URL: http://issues.apache.org/jira/browse/DERBY-1347
>      Project: Derby
>         Type: Bug

>   Components: Test
>     Reporter: David Van Couvering

> In the method examineExpectedInDerbyNetClient, the code validates the error code using
the following:
> 	return 
> 	    sqlex.getSQLState().equals("08006") && 
> 	    sqlex.getErrorCode() == SqlCode.disconnectError.getCode();
> SqlCode is an internal class and our tests shouldn't rely on it.  We should probably
just use the error code explicitly, or define a testing class that contains some of the error
codes that Derby returns.
> Also: are our error codes even a documented public interface?

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message