db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Van Couvering <David.Vancouver...@Sun.COM>
Subject Re: [jira] Reopened: (DERBY-1302) Indent source files touched in DERBY-326
Date Wed, 31 May 2006 16:42:54 GMT
+1, if this is impacting our ability to do merges we should back this 
change out.

Knut Anders Hatlen (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/DERBY-1302?page=all ]
>      
> Knut Anders Hatlen reopened DERBY-1302:
> ---------------------------------------
> 
> 
> I think these changes should be backed out for two reasons:
> 
>   1) This is not the right time to reindent so large parts of the
>      code, as it makes merging to the 10.1 branch difficult.
> 
>   2) All of DRDAConnThread (which is one of the largest classes in
>      Derby) has been reindented to a style that is not used in any
>      other Derby class (tab width = 8).
> 
> If we want to reindent large parts of the code, I think we should do
> it sometime after 10.1.3 is released and before the 10.2 branch is
> created, and we should try to use a style that is used elsewhere in
> the code (I prefer tab-free code myself).
> 
>> Indent source files touched in DERBY-326
>> ----------------------------------------
>>
>>          Key: DERBY-1302
>>          URL: http://issues.apache.org/jira/browse/DERBY-1302
>>      Project: Derby
>>         Type: Sub-task
> 
>>     Reporter: Tomohito Nakayama
>>     Assignee: Tomohito Nakayama
>>  Attachments: DDMWriter.java, DERBY-1302.patch, DERBY-1302_2.patch
>>
>> Through DERBY-326,some of source code was found not to be orderly indented.
>> In this task, these files are to be orderly indented.
> 

Mime
View raw message