db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1245) Add o.a.derby.client.am.ClobWriter test coverage
Date Wed, 17 May 2006 22:02:06 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1245?page=comments#action_12412246 ] 

Kathey Marsden commented on DERBY-1245:
---------------------------------------

I took a brief look at the patch  and was concerned about encoding safety, but maybe it is
ok based on the java.io.Writer definition for write.  I am not really sure.

     public void write(int c) {
         StringBuffer sb = new StringBuffer(clob_.string_.substring(0, (int) offset_ - 1));
-        sb.append(c);
+        sb.append((char)c);

Perhaps you could add this test to encodingTests suite and maybe someone else could take a
look at this too.


> Add o.a.derby.client.am.ClobWriter test coverage
> ------------------------------------------------
>
>          Key: DERBY-1245
>          URL: http://issues.apache.org/jira/browse/DERBY-1245
>      Project: Derby
>         Type: Sub-task

>   Components: Test, Network Client
>     Reporter: Anders Morken
>     Assignee: Anders Morken
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: DERBY-1245-collateraldamage-v1.patch, DERBY-1245-lobStream-v1.patch
>
> org.apache.derby.client.am.ClobWriter.java is currently not covered by functional tests.
I'll patch something up in jdbcapi/lobStreams.java and stick a diff here when it works. =)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message