db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Korneliussen (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1234) Verify that we raise SQLException when calling methods on closed java.sql objects
Date Thu, 04 May 2006 12:19:18 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1234?page=comments#action_12377780 ] 

Andreas Korneliussen commented on DERBY-1234:
---------------------------------------------

I think maybe some of the added calls to checkIfClosed() are not necessary. I.e if you call
rs.getInt("intcolumt"),   checkIfClosed() is called three times (i.e if you follow the stack):

getInt(String columnName) 
 -> getInt(int columnName)
   -> getColumn(int columnName)

These are three calls for checkIfClosed() instead of one. I think it is sufficient with a
check in getColumn().
Similar issue with updateXXX() and calls to checksBeforeUpdateXXX..()


> Verify that we raise SQLException when calling methods on closed java.sql objects
> ---------------------------------------------------------------------------------
>
>          Key: DERBY-1234
>          URL: http://issues.apache.org/jira/browse/DERBY-1234
>      Project: Derby
>         Type: Improvement

>   Components: JDBC
>     Versions: 10.2.0.0
>     Reporter: Rick Hillegas
>     Assignee: Knut Anders Hatlen
>      Fix For: 10.2.0.0
>  Attachments: derby-1234-part1.diff, derby-1234-part2.diff, derby-1234-part2.stat, derby-1234-part3.diff,
derby-1234-part3.stat, derby-1234-part4.diff, derby-1234-part4.stat, derby-1234-part5.diff,
derby-1234-part5.stat, derby-1234-v1.diff, derby-1234-v1.stat
>
> The next rev of the JDBC4 spec will clarify that databases should raise SQLException
when an application calls methods on closed sql objects: ResultSet, Preparedstatement, CallableStatement,
Connection, and Statement. We should verify that we conform.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message