db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1302) Indent source files touched in DERBY-326
Date Fri, 19 May 2006 16:56:31 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1302?page=comments#action_12412538 ] 

Dag H. Wanvik commented on DERBY-1302:
--------------------------------------

I think it is good to clean up the sources a bit!  Just a couple of
comments: I am a bit puzzled this formatting change, which I don't
think is very common practice in Derby:

while
{
    // get a new session
    :
changed to: 

while(!closed())
    {
        // get a new session
        :

etc. If anything, I think the brace should start on the previous line,
which is used elsewhere in Derby (mostly). Effectively it indents the
loop body eight spaces, which is expensive, IMHO. There are several
instances of this.

It seems you have not sanitized the file wrt to tabs as whitespace,
either, but I know one could argue the diffs would be too extensive.
Maybe the getting rid of the physical tabs is a lost cause.. :-( I
just wish they would go away...



> Indent source files touched in DERBY-326
> ----------------------------------------
>
>          Key: DERBY-1302
>          URL: http://issues.apache.org/jira/browse/DERBY-1302
>      Project: Derby
>         Type: Sub-task

>     Reporter: Tomohito Nakayama
>     Assignee: Tomohito Nakayama
>  Attachments: DERBY-1302.patch
>
> Through DERBY-326,some of source code was found not to be orderly indented.
> In this task, these files are to be orderly indented.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message