Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <93583891.1145054161297.JavaMail.jira@brutus>
Date: Fri, 14 Apr 2006 22:36:01 +0000 (GMT+00:00)
From: "Andrew McIntyre (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Updated: (DERBY-826) sysinfo does not report the version of
 derby.jar if the class does not explictly contain it.
In-Reply-To: <161422919.1137694422284.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/DERBY-826?page=all ]

Andrew McIntyre updated DERBY-826:
----------------------------------

    Attachment: derby-826_v2.diff

Thanks for the helpful review, Bryan. 

1 - Yes, I removed this and an unused import from an experiment I had done previously.

2 & 3 - A great suggestion on 3. I pulled out the formatting code and put it into a new method, formatURL. This also normalizes the path separators in the jar/directory locations, so the duplicates are properly removed for 2.

4 - Added additional javadoc comments to mergeZips.

Let me know if you think this needs any more refinement, otherwise I'd like to commit it soon.

> sysinfo does not report the version of derby.jar if the class does not explictly contain it.
> --------------------------------------------------------------------------------------------
>
>          Key: DERBY-826
>          URL: http://issues.apache.org/jira/browse/DERBY-826
>      Project: Derby
>         Type: Bug

>   Components: Tools
>     Versions: 10.2.0.0
>     Reporter: Daniel John Debrunner
>     Assignee: Andrew McIntyre
>     Priority: Minor
>  Attachments: derby-826.diff, derby-826_v2.diff
>
> derby.jar is in the classpath here indirectly because derbynet.jar includes it through a manifest entry.
> java -cp jars/sane/derbynet.jar org.apache.derby.tools.sysinfo
> ------------------ Java Information ------------------
> Java Version:    1.4.2
> Java Vendor:     IBM Corporation
> Java home:       C:\Program Files\IBM\Java142\jre
> Java classpath:  jars/sane/derbynet.jar
> OS name:         Windows XP
> OS architecture: x86
> OS version:      5.1
> Java user name:  djd
> Java user home:  C:\Documents and Settings\Administrator
> Java user dir:   c:\_work\svn_clean2\trunk
> java.specification.name: Java Platform API Specification
> java.specification.version: 1.4
> --------- Derby Information --------
> JRE - JDBC: J2SE 1.4.2 - JDBC 3.0
> [C:\_work\svn_clean2\trunk\jars\sane\derbynet.jar] 10.2.0.0 alpha - (370500M)
> ------------------------------------------------------
> ----------------- Locale Information -----------------
> Current Locale :  [English/United States [en_US]]
> Found support for locale: [de_DE]
>          version: 10.2.0.0 alpha - (370500M)
> Found support for locale: [es]
>          version: 10.2.0.0 alpha - (370500M)
> Found support for locale: [fr]
>          version: 10.2.0.0 alpha - (370500M)
> Found support for locale: [it]
>          version: 10.2.0.0 alpha - (370500M)
> Found support for locale: [ja_JP]
>          version: 10.2.0.0 alpha - (370500M)
> Found support for locale: [ko_KR]
>          version: 10.2.0.0 alpha - (370500M)
> Found support for locale: [pt_BR]
>          version: 10.2.0.0 alpha - (370500M)
> Found support for locale: [zh_CN]
>          version: 10.2.0.0 alpha - (370500M)
> Found support for locale: [zh_TW]
>          version: 10.2.0.0 alpha - (370500M)
> ------------------------------------------------------

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira