Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <89909220.1146056284065.JavaMail.root@brutus>
Date: Wed, 26 Apr 2006 12:58:04 +0000 (GMT+00:00)
From: "Dyre Tjeldvoll (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Updated: (DERBY-1235) Move isPoolable() and setPoolable()
 from PreparedStatement to Statement
In-Reply-To: <19291877.1145553125744.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/DERBY-1235?page=all ]

Dyre Tjeldvoll updated DERBY-1235:
----------------------------------

    Attachment: derby-1235.v2.diff
                derby-1235.v2.stat

Attaching a new patch based on Kristian's very valuable review comments. The new patch
- Replaces references to PreparedStatement with Statement in Javadoc comments.
- Makes the same change for the Network client.
- Changes the default value for isPoolable to false for Statement, while keeping true as the default for PreparedStatement (isPoolable was made protected so that it can be modified by derived classes). Since CallableStatement inherits from PreparedStatement, it too will be poolable by default.
- Added a test case to StatementTest.java to test isPoolable(), setPoolable() and the default value for Statement.
- TestPreparedStatement.java already tests this for PreparedStatements (including the correct default).

> Move isPoolable() and setPoolable() from PreparedStatement to Statement
> -----------------------------------------------------------------------
>
>          Key: DERBY-1235
>          URL: http://issues.apache.org/jira/browse/DERBY-1235
>      Project: Derby
>         Type: Improvement

>   Components: JDBC
>     Versions: 10.2.0.0
>     Reporter: Rick Hillegas
>     Assignee: Dyre Tjeldvoll
>      Fix For: 10.2.0.0
>  Attachments: derby-1235.v1.diff, derby-1235.v1.stat, derby-1235.v2.diff, derby-1235.v2.stat, derbyall_report.v1.txt
>
> An upcoming release of jdk1.6 will move isPoolable() and setPoolable() from PreparedStatement to Statement. We should conform.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira