db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <derby-...@db.apache.org>
Subject [jira] Updated: (DERBY-1224) Remove unused variables in DatabaseMetaData
Date Mon, 17 Apr 2006 22:02:18 GMT
     [ http://issues.apache.org/jira/browse/DERBY-1224?page=all ]

Knut Anders Hatlen updated DERBY-1224:
--------------------------------------

    Attachment: derby-1224-v1.diff
                derby-1224-v1.stat

The attached patch removes the unused variables in
DatabaseMetaData. Derbyall passed on Sun JVM 1.5 (Solaris 10
x86). Please review.

> Remove unused variables in DatabaseMetaData
> -------------------------------------------
>
>          Key: DERBY-1224
>          URL: http://issues.apache.org/jira/browse/DERBY-1224
>      Project: Derby
>         Type: Improvement

>   Components: JDBC, Network Client, Performance
>     Versions: 10.2.0.0
>     Reporter: Knut Anders Hatlen
>     Assignee: Knut Anders Hatlen
>     Priority: Minor
>  Attachments: derby-1224-v1.diff, derby-1224-v1.stat
>
> org.apache.derby.client.am.DatabaseMetaData has a number of instance
> variables which don't seem to have any purpose:
>   lastGetColumnPrivilegesResultSet_
>   lastGetColumnsResultSet_
>   lastGetForeignKeysResultSet_
>   lastGetPrimaryKeysResultSet_
>   lastGetProcedureColumnsResultSet_
>   lastGetProceduresResultSet_
>   lastGetSpecialColumnsResultSet_
>   lastGetStatisticsResultSet_
>   lastGetTablePrivilegesResultSet_
>   lastGetTablesResultSet_
>   lastGetUDTsResultSet_
>   lastGetTypeInfoResultSet_
>   lastGetAttrResultSet_
>   lastGetSuperTypesResultSet_
>   lastGetSuperTablesResultSet_
> Each lastGetXXXResultSet_ variable is set when the corresponding
> getXXX method is invoked. However, the variables are never read, so
> they could just as well be removed. Removing them will reduce the
> memory footprint.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message