db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kristian Waagan <Kristian.Waa...@Sun.COM>
Subject Re: jdbc4/ParameterMetaDataWrapperTest.junit listed twice in jdbc40.runall
Date Tue, 25 Apr 2006 12:41:17 GMT
Oystein Grovlen - Sun Norway wrote:
> It is not a good idea to always add new items at the end of a list. That 
> increases the risk of conflicts between check-ins.  I think for most of 
> the test suites one has tried to maintain an alphabetical ordering.

Yes, I agree. I did add the new tests in alphabetical order in my patch, 
but I can't remember having done anything explicit about the 
ParameterMetaDataWrapperTest.

There is also a comment there about the missing newline, which I for 
sure did not add myself. Is this something that is done/detected 
automatically by Subversion?



--
Kristian

> 
> -- 
> Øystein
> 
> Kristian Waagan wrote:
>> Hello,
>>
>> ParameterMetaDataWrapperTest.junit is listed twice in 
>> suites/jdbc40.runall. I suppose this is a mistake. Can a committer 
>> please correct this?
>> I do not plan to add a Jira issue for this...
>>
>>
>> The revisions in which the lines were added:
>> 396638  jdbc4/ParameterMetaDataWrapperTest.junit
>> 396669  jdbc4/ParameterMetaDataWrapperTest.junit
>>
>>
>> It was my patch that was committed last, and the relevant part looks 
>> like this:
>> Index: 
>> java/testing/org/apache/derbyTesting/functionTests/suites/jdbc40.runall
>> ===================================================================
>> --- 
>> java/testing/org/apache/derbyTesting/functionTests/suites/jdbc40.runall
>> (revision 396521)
>> +++ 
>> java/testing/org/apache/derbyTesting/functionTests/suites/jdbc40.runall
>> (working copy)
>> @@ -5,10 +5,13 @@
>>  jdbc4/TestDbMetaData.java
>>  jdbc4/TestJDBC40Exception.java
>>  jdbc4/StatementEventsTest.junit
>> +jdbc4/BlobTest.junit
>>  jdbc4/CallableStatementTest.junit
>> +jdbc4/ClobTest.junit
>> +jdbc4/ResultSetTest.junit
>>  jdbc4/RowIdNotImplementedTest.junit
>>  jdbc4/StatementTest.junit
>>  jdbc4/DataSourceTest.junit
>>  jdbc4/ResultSetMetaDataTest.junit
>>  jdbc4/EmbeddedBrokeredConnectionWrapperTest.junit
>> -jdbc4/ParameterMetaDataWrapperTest.junit
>> \ No newline at end of file
>> +jdbc4/ParameterMetaDataWrapperTest.junit
>>
>>
>> The other one looked like this:
>> Index: 
>> java/testing/org/apache/derbyTesting/functionTests/suites/jdbc40.runall
>> ===================================================================
>> --- 
>> java/testing/org/apache/derbyTesting/functionTests/suites/jdbc40.runall 
>> (revision 396542)
>> +++ 
>> java/testing/org/apache/derbyTesting/functionTests/suites/jdbc40.runall 
>> (working copy)
>> @@ -11,4 +11,5 @@
>>  jdbc4/DataSourceTest.junit
>>  jdbc4/ResultSetMetaDataTest.junit
>>  jdbc4/EmbeddedBrokeredConnectionWrapperTest.junit
>> -jdbc4/ParameterMetaDataWrapperTest.junit
>> \ No newline at end of file
>> +jdbc4/ParameterMetaDataWrapperTest.junit
>> +jdbc4/AutoloadTest.junit
>>
>>
>> Not sure why things went a little wrong...
>>
>>
>> thanks,
>> -- 
>> Kristian
> 
> 


Mime
View raw message